Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "🏗 Update @percy/percy-puppeteer to v1.x" #25213

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

estherkim
Copy link
Collaborator

Reverts #25176

gulp visual-diff --nobuild --empty throws an error. Example here: https://travis-ci.org/ampproject/amphtml/jobs/601550094#L351-L361

@amp-owners-bot
Copy link

Hey @danielrozenberg, these files were changed:

  • build-system/tasks/visual-diff/helpers.js
  • build-system/tasks/visual-diff/index.js
  • build-system/tasks/visual-diff/package.json
  • build-system/tasks/visual-diff/percy-assets-loader.js
  • build-system/tasks/visual-diff/yarn.lock

Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, reverting seems the best course of action right now to unblock master.

@estherkim estherkim merged commit d134d30 into master Oct 23, 2019
danielrozenberg added a commit to danielrozenberg/amphtml that referenced this pull request Oct 23, 2019
danielrozenberg added a commit that referenced this pull request Oct 23, 2019
* Revert "Revert "🏗 Update @percy/percy-puppeteer to v1.x (#25176)" (#25213)"

This reverts commit d134d30.

* Do not expect a build when running with --empty
joshuarrrr pushed a commit to Parsely/amphtml that referenced this pull request Oct 23, 2019
joshuarrrr pushed a commit to Parsely/amphtml that referenced this pull request Oct 23, 2019
…ampproject#25221)

* Revert "Revert "🏗 Update @percy/percy-puppeteer to v1.x (ampproject#25176)" (ampproject#25213)"

This reverts commit d134d30.

* Do not expect a build when running with --empty
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
…ampproject#25221)

* Revert "Revert "🏗 Update @percy/percy-puppeteer to v1.x (ampproject#25176)" (ampproject#25213)"

This reverts commit d134d30.

* Do not expect a build when running with --empty
@rsimha rsimha deleted the revert-25176-percy-puppeteer branch February 13, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants