Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βœ… Tests: Update @percy/agent to fix memory leak #25335

Closed
wants to merge 2 commits into from

Conversation

Robdel12
Copy link

What is this?

Thank you @danielrozenberg for opening up this issue: percy/percy-agent#402 we recently shipped something that should fix this issue πŸ‘

This also removes the PERCY_PROJECT env var. I'm assuming the old Puppeteer SDK needed that env var, but all new agent based SDKs don't need that env var anymore (just PERCY_TOKEN).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

πŸ“ Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@danielrozenberg
Copy link
Member

Hi @Robdel12, thanks for the quick fix! We got a renovate-bot PR (#25334) to fix this, and your PR removes the PERCY_PROJECT variables (which we don't use anymore as you correctly stated) but it leaves a few more references to it (there are some places where it's percy_project, in lower-case) - do you want to push another commit to this or should I merge the other PR and remove that dangling env variable in a separate PR? :)

@Robdel12
Copy link
Author

Ah, great point! I think merging the dependabot PR and circling back with another PR should do it πŸ˜ƒ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants