Fix: fonts.css template doesn't correctly parse the style
or weight
options
#1399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the fonts.css.template logic, so that it correctly coerces the null values when
font.style
andfont.weight
are undefined.The current logic is using null coersion (the
??
operator), which means that the value is only written whenfont.style
is null - which of course then throws an error because it tries to readvalue
from an undefined object.Then, if
font.style
andfont.weight
are defined, the output is[object Object][object Object]
, because the actual statement is never reached.Issue #, if available:
Description of changes:
Update the logic to use a ternary statement with empty strings as the fallbacks.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.