refactor/es6 module test #1405
Merged
refactor/es6 module test #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
jorenbroekema
previously approved these changes
Dec 9, 2024
dbanksdesign
previously approved these changes
Dec 9, 2024
Signed-off-by: Tobias Kuppens Groot <[email protected]>
allTokens was an empty array. however it is not used by the format function 'javascript/esm' therefore it could also be safely removed Signed-off-by: Tobias Kuppens Groot <[email protected]>
jorenbroekema
dismissed stale reviews from dbanksdesign and themself
via
0249bc9
jorenbroekema
force-pushed
the
refactor/es6-module-test
branch
from
12dc4ee to
0249bc9
Compare
dbanksdesign
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
allTokensallTokens: convertTokenData(DTCGTokens, { output: 'array' })since it is not used by the formatterjavascript/esm, thus the value ofallTokensdoes not matter and tests do not fail.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.