Add proper support for CDT packages #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuylermartin45
approved these changes
Jul 8, 2024
| @@ -196,6 +196,22 @@ def expand_compiler(lang): | |||
| else: | |||
| return f"{compiler}_{selector_dict.get('target_platform', 'win-64')}" | |||
|
|
|||
| # Based on https://github.com/conda/conda-build/blob/6d7805c97aa6de56346e62a9d1d3582cac00ddb8/conda_build/jinja_context.py#L559-L575 # pylint: disable=line-too-long | |||
There was a problem hiding this comment.
Thank you for including the link!
| @@ -196,6 +196,22 @@ def expand_compiler(lang): | |||
| else: | |||
| return f"{compiler}_{selector_dict.get('target_platform', 'win-64')}" | |||
|
|
|||
| # Based on https://github.com/conda/conda-build/blob/6d7805c97aa6de56346e62a9d1d3582cac00ddb8/conda_build/jinja_context.py#L559-L575 # pylint: disable=line-too-long | |||
| def expand_cdt(package_name: str) -> str: | |||
| arch = selector_dict["target_platform"].split("-", 1)[-1] | |||
There was a problem hiding this comment.
Should we add some unit test examples for this function?
cbouss
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds proper support for CDT packages. The logic mostly follows what conda-build does. I say mostly because it's slightly simpler.