A few small fixes and clean ups #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up dependencies a bit. Signed-off-by: Andrii Nakryiko <[email protected]>
Add this option to silence newer LD's complaining about potential executable stack. Signed-off-by: Andrii Nakryiko <[email protected]>
Mass attacher has a feature to filter some functions, but it's never used, so get rid of it for now. Signed-off-by: Andrii Nakryiko <[email protected]>
BPF code is always 64-bit with 64-bit architecture rules, including u64 alignment, etc. struct func_info exposes an interesting corner case where all the fields are at correct offsets regardless of 32-bit or 64-bit architecture, but the size of the struct differs because on 64-bit architecture alignment of `struct func_info` is 8 bytes, and thus the size is 56 bytes, while on 32-bit architecture u64 still has 4-byte alignment, so there is no need for extra 4 bytes of padding, leading to `sizeof(struct func_info) == 52`. Fix this issue by forcing alignment to be 8. Reported-by: Michel Lind <[email protected]> Signed-off-by: Andrii Nakryiko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.