Update HW test to use environmental variables #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Travis F. Collins <[email protected]>
commodo
reviewed
Oct 19, 2020
| @@ -52,7 +52,9 @@ int main(void) | |||
|
|
|||
| unsigned long rates[] = {520888, 600000, 1000000, 10000000, 20000000, 40000000, 60000000}; | |||
|
|
|||
| char * uri = "ip:192.168.2.1"; | |||
| const char* uri = getenv("URI_AD9361"); | |||
| if (uri == NULL) | |||
There was a problem hiding this comment.
why not leave defaults here?
if (uri == NULL)
uri = "ip:192.168.2.1;
if the IP doesn't work, if (ctx == NULL) should bail
There was a problem hiding this comment.
I would say we don't do this since
- You don't have to wait for timeouts when running tests
- You do not accidentally run a test on a board you don't explicitly want to (ran into this issue with M2K attached instead of Pluto)
There was a problem hiding this comment.
Fine by me
Will merge tomorrow if no objections
There was a problem hiding this comment.
oh; just thought of something;
would a message be a good idea? in case the env-vars aren't defined?
commodo
approved these changes
Oct 19, 2020
|
one note; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is designed to make the library testable with the hardware testing harness where URIs are parameterizable.
This branch has been running fine in the harness for ~2 weeks.
Signed-off-by: Travis F. Collins [email protected]