-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use originator logic to fill supplier #1980
Conversation
Signed-off-by: Christopher Phillips <[email protected]>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch
|
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
Update the root package to have supplier as noassertion since this is a manually synthesized package as part of the source object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this updated intentionally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 -- per discussion, just add a NOASSERTION supplier to the root package
Signed-off-by: Christopher Phillips <[email protected]>
* feat: use Originator to fill supplier for NTIA minimum --------- Signed-off-by: Christopher Phillips <[email protected]>
Summary
Syft should be filling in the supplier information to meet NTIA minimum standards for SPDX sbom generated by the tool.
Partially Addressing #1961
There are additional refinements we can make where supplier can get it's own function when we determine a good fence for when one field should specify one value vs another:
A good example:
Supplier
Originator
In this case
NOASSERTION
is returned when: