feat: Java dependency graph information #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <[email protected]>
kzantow
force-pushed
the
feat/java-dependency-graph
branch
from
416abdd to
0bb3031
Compare
kzantow
commented
Oct 21, 2024
kzantow
commented
Oct 21, 2024
Signed-off-by: Keith Zantow <[email protected]>
kzantow
commented
Oct 21, 2024
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
kzantow
commented
Oct 22, 2024
kzantow
commented
Oct 22, 2024
| PomProperties: &pkg.JavaPomProperties{ | ||
| GroupID: id.GroupID, | ||
| ArtifactID: id.ArtifactID, | ||
| Scope: r.ResolveProperty(ctx, pom, dep.Scope), |
There was a problem hiding this comment.
The PomProperties has the scope? This doesn't seem right, but this was the existing behavior.
There was a problem hiding this comment.
agreed -- we should make a syft 2.0 for this and mark the field as deprecated. There is a discussion in #572 on how to mark dev/test deps on edges, but for now we've elected to not track these.
wagoodman
reviewed
Oct 23, 2024
Signed-off-by: Keith Zantow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements dependency graph information for Java packages. This applies primarily to these scenarios:
For example: a user scanning a
.warfile with multiple embedded.jarfiles, the topmost package representing the.warfile will have dependency relationships from the specific packages surfaced from the included.jarfiles.Additionally, this PR includes a refactoring the internal Maven resolver functionality to an internal package to provide clearer boundaries of usage vs. internal methods.
Type of change
Checklist: