Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow validation functions to be asynchronous #158

Merged
merged 4 commits into from
Sep 25, 2018
Merged

Allow validation functions to be asynchronous #158

merged 4 commits into from
Sep 25, 2018

Conversation

rafaelverger
Copy link
Contributor

FIX #157

@coveralls
Copy link

coveralls commented Sep 24, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling dc152e9 on rafaelverger:allow_async_validation into 4ff7420 on andersonba:master.

andersonba
andersonba approved these changes Sep 24, 2018
View reviewed changes
Copy link
Owner

@andersonba andersonba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you.

For better performance, I would like you to remove unnecessary map, decreasing the numbers of loops.

@rafaelverger
Copy link
Contributor Author

@andersonba updated!

andersonba
andersonba approved these changes Sep 25, 2018
View reviewed changes
Copy link
Owner

@andersonba andersonba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good!

@andersonba andersonba merged commit 250bd25 into andersonba:master Sep 25, 2018
@rafaelverger rafaelverger deleted the allow_async_validation branch September 25, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersonba andersonba andersonba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaelverger @coveralls @andersonba