Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set webpack to have custom props for node and browser #19

Merged
merged 4 commits into from
Oct 20, 2017
Merged

Set webpack to have custom props for node and browser #19

merged 4 commits into from
Oct 20, 2017

Conversation

rafaelverger
Copy link
Contributor

Closes #18

andersonba
andersonba requested changes Oct 20, 2017
View reviewed changes
Copy link
Owner

@andersonba andersonba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using webpack-node-externals, all modules in node_modules should not be bundled, right?
We have to move some dependencies from devDependencies, d u agree?

webpack.config.js Outdated
@@ -34,8 +31,35 @@ module.exports = {

plugins: [
new CheckerPlugin(),
/*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to remove these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah :)

webpack.config.js
const { CheckerPlugin } = require('awesome-typescript-loader')

const srcPath = path.join(__dirname, '/src');
const libPath = path.join(__dirname, '/lib');

module.exports = {
context: srcPath,
const nodeExternals = require('webpack-node-externals');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing in package.json/yarn.lock

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@rafaelverger
Copy link
Contributor Author

@andersonba hmm that's right, I'm checking now what we should have as deps and devdeps :)

@rafaelverger
Copy link
Contributor Author

@andersonba apparently only lodash is needed as a "real" dependency

@andersonba andersonba merged commit 2dc225d into andersonba:master Oct 20, 2017
@rafaelverger rafaelverger deleted the bugfix/18 branch October 20, 2017 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersonba andersonba andersonba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelverger @andersonba