Improve multi-executors RuleTypes flow #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersonba
requested changes
Oct 25, 2017
| } catch (e) { | ||
| let expectedError = false; |
There was a problem hiding this comment.
[minor] renames to expectedReply
src/core/exceptions.ts
Outdated
|
|
||
| export function PauseRuleTypeExecutors(name: string) { | ||
| this.key = 'pauseRuleTypeExecutors'; | ||
| this.message = `Rule "${name}" should pause exection`; |
src/types.ts
Outdated
|
|
||
| export interface RuleTypeExecutor { | ||
| validators?: RuleValidator[]; | ||
| transform?: (value: any, rule?: Rule, bot?: YveBot) => Promise<any>; |
There was a problem hiding this comment.
create a type RuleTypeTransform
src/core/bot.ts
Outdated
| @@ -121,3 +126,7 @@ export class YveBot { | |||
| YveBot.prototype.types = new Types; | |||
| YveBot.prototype.actions = new Actions; | |||
| YveBot.prototype.validators = new Validators; | |||
|
|
|||
|
|
|||
| YveBot.Exceptions = Exceptions; | |||
There was a problem hiding this comment.
use exceptions to keep the pattern
YveBot.exceptions.RuleNotFound
src/core/bot.ts
Outdated
|
|
||
|
|
||
| YveBot.Exceptions = Exceptions; | ||
| YveBot.WaitForUserInputExecutor = WaitForUserInput; |
There was a problem hiding this comment.
YveBot.executors = new Executors
to be accessed by YveBot.executors.WaitForUserInput
src/core/types.ts
Outdated
| import * as utils from './utils'; | ||
|
|
||
| const types = { | ||
|
|
||
| export const WaitForUserInput: RuleTypeExecutor = { |
src/core/bot.ts
Outdated
| @@ -23,6 +25,9 @@ function sanitizeRule(rule: Rule): Rule { | |||
| } | |||
|
|
|||
| export class YveBot { | |||
| static Exceptions: any; | |||
src/core/bot.ts
Outdated
| @@ -23,6 +25,9 @@ function sanitizeRule(rule: Rule): Rule { | |||
| } | |||
|
|
|||
| export class YveBot { | |||
| static Exceptions: any; | |||
| static WaitForUserInputExecutor: typeof WaitForUserInput; | |||
src/core/controller.ts
Outdated
| this.bot.store.unset(`executors.${rule.name}.currentIdx`); | ||
| } | ||
|
|
||
| async executeRuleTypeExecutors(rule: Rule, lastAnswer: Answer | Answer[]): Promise<any> { |
There was a problem hiding this comment.
Promise<Answer | Answer[]> breaks?
There was a problem hiding this comment.
There is no guarantee that return will be answer... the return will be whatever transform + validators returns
andersonba
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes makes "how to pause executors" as explicit as possible.