Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new field type: StringSearch #27

Merged
merged 13 commits into from
Oct 31, 2017
Merged

Create new field type: StringSearch #27

merged 13 commits into from
Oct 31, 2017

Conversation

rafaelverger
Copy link
Contributor

@rafaelverger rafaelverger commented Oct 30, 2017 •
edited
Loading

  • New multi-step field type to query external server with users input and show its results
  • Custom config for defined messages
  • Custom config for server's response translation
  • Improve readme with this new field
  • Tests

Closes #29

@rafaelverger rafaelverger changed the title Create new field type: StringSearch [WIP] Create new field type: StringSearch Oct 30, 2017
andersonba
andersonba requested changes Oct 30, 2017
View reviewed changes
Copy link
Owner

@andersonba andersonba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done !!! 👏
Check my comment

src/core/types.ts Outdated
message = `${messages.didYouMean}: ${results[0].label}?`;
options = [
{ label: 'Sim', value: results[0].value },
{ label: 'Não', value: null },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use translations here

@rafaelverger rafaelverger changed the title [WIP] Create new field type: StringSearch Create new field type: StringSearch Oct 31, 2017
@andersonba
Copy link
Owner

You forgot to add the yes/no messages in docs.
I was thinking so, we should have a config default with generic messages, like as "no found results", "type the word to search"...
What do you think about it?

@rafaelverger
Copy link
Contributor Author

It makes sense, @andersonba and would those messages be able to be overridden by rule's configs?

@andersonba
Copy link
Owner

Yeah! Should be overriden.

@andersonba andersonba merged commit 34b170d into andersonba:master Oct 31, 2017
@rafaelverger rafaelverger deleted the nunes/new_fieldType_stringSearch branch October 31, 2017 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersonba andersonba andersonba approved these changes

Assignees
No one assigned
Labels
enhancement plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelverger @andersonba