Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some CardDav servers put "\," into vCard downloads of attributes #90

Closed
derwok opened this issue Jan 12, 2019 · 0 comments
Closed

some CardDav servers put "\," into vCard downloads of attributes #90

derwok opened this issue Jan 12, 2019 · 0 comments

Comments

@derwok
Copy link

derwok commented Jan 12, 2019

TL;DR: Pull request in preparation.

Some CardDav servers - e.g., Baikal (sabre/dav) - sends a attribute with embedded comma (,) in XML with "\,". The quote backslash survives all our processing chain right into the Fritz!Box upload.

Example: Display in CardDav-Editor:
grafik

Example: Display in Fritz!Box Browser UI:
grafik

Root cause is the specified BACKSLASH quoting of COMMA, SEMICOLON & BACKSLASH described in the vCard standard:
https://tools.ietf.org/html/rfc6350#section-3.4

As a consequence, FritzFon displays ugly "\" in some contacts names. And even breaks Phone numbers with comma. (A comma in a phone number is a pause!)

Solution: replace \{SPECIALCHAR} => {SPECIALCHAR} in values in the vCard parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant