Fix memory leak in promise_manager (#79)

andogq · Aug 28, 2024 · b0bea9c · b0bea9c
2 parents 4ff5b54 + b329d2e
commit b0bea9c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/.changes/fix-memory-leak.md b/.changes/fix-memory-leak.md
@@ -0,0 +1,5 @@
+---
+"@qubit-rs/client": patch:bug
+---
+
+Fix memory leak in promise manager due to holding references to resolved promises.
diff --git a/packages/client/src/util/promise_manager.ts b/packages/client/src/util/promise_manager.ts
@@ -19,6 +19,7 @@ export function create_promise_manager() {
     resolve: (response: RpcResponse<unknown>) => {
       const handler = promises[response.id];
       if (handler) {
+        delete promises[response.id];
         handler(response);
       }
     },