Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace let/const with var #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replace let/const with var #31

wants to merge 1 commit into from

Conversation

sonnyp
Copy link
Contributor

@sonnyp sonnyp commented Nov 6, 2013

No description provided.


// Format of the string encoded meta data. If the name contains "^" or "$"
// we will generate a regular expression from the value, with those special
// characters as prefix/suffix.
const META_DATA_ENCODING = ["region",
var META_DATA_ENCODING = ["region",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure const is not supported? or is it just let? If you want to change this please also adjust the indentation below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const isn't supported in E10

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE10? Who uses that? ;) Ok, please fix the indentation and I will merge it.

@sonnyp
Copy link
Contributor Author

sonnyp commented Jan 27, 2014

@wald-tq Thanks!
sorry for the delay :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants