Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup with sh(sortedmulti()) script #64

Closed
notmandatory opened this issue Jan 16, 2025 · 5 comments · Fixed by #65
Closed

Setup with sh(sortedmulti()) script #64

notmandatory opened this issue Jan 16, 2025 · 5 comments · Fixed by #65

Comments

@notmandatory
Copy link

How do I setup a custom 2-3 sh(sortedmulti(2,key1,key2,key3)) descriptor ? This is the format that Unchained uses and I haven't been able to set it up manually in bitcoin-safe. When I enter the descriptor and keys manually the descriptor gets switched to sh(wsh(sortedmulti(2,key1,key2,key3))).

bitcoin-safe version: 1.0.0
OS: MacOS

@andreasgriffin
Copy link
Owner

Will check it asap.

@andreasgriffin
Copy link
Owner

andreasgriffin commented Jan 16, 2025

The short answer is: Bitcoin Safe does not support creating a p2sh multisig, because the fee burden for p2sh multisig is substantial. Perhaps I should reconsider adding support for importing older wallets.

In any case: Clearly, Bitcoin Safe should prevent (and warn) you from copying unsupported descriptor types in the edit box. --> I will create a PR for this.

@notmandatory
Copy link
Author

Agree these legacy p2sh script types are not ideal. Hopefully Unchained will be able to upgrade their software soon.
cc: @bucko13

@andreasgriffin
Copy link
Owner

I am testing and so far, I can only reproduce that Bitcoin Safe behaves correctly, in NOT doing anything with values of a descriptor type it doesn't support. (A warning message would be helpful though).

After discussion, it turns out that a warning message is important here to inform the user, that a copy&pasted descriptor was NOT accepted.

@bucko13
Copy link

bucko13 commented Jan 16, 2025

Agree these legacy p2sh script types are not ideal. Hopefully Unchained will be able to upgrade their software soon. cc: @bucko13

An "upgrade" in that unchained moves to segwit completely is not in the cards. We'll support legacy indefinitely. However adding p2wsh support is very much in the cards and should be released soon. Other software we maintain (for example https://github.com/caravan-bitcoin/caravan) has supported p2wsh wallets for years though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants