Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health Tablist #699

Closed
ImYenil opened this issue Mar 5, 2023 · 20 comments
Closed

Health Tablist #699

ImYenil opened this issue Mar 5, 2023 · 20 comments
Assignees
Labels
enhancement New feature or request

Comments

@ImYenil
Copy link
Contributor

ImYenil commented Mar 5, 2023

Is your feature request related to a problem? Please describe.
My server users are complaining that tablist health is displayed like that.

Describe the solution you'd like
make it display health like the picture.
2023-03-05_20 18 02

Describe alternatives you've considered
None

Additional context
I have attached a picture above

@ImYenil ImYenil added the enhancement New feature or request label Mar 5, 2023
@andrei1058
Copy link
Owner

I'm not sure what you mean

@porudev
Copy link

porudev commented Mar 7, 2023

There should be an option to disable the 10 Hearts and only display the yellow numbers, please check the config before posting thing like this

@ImYenil
Copy link
Contributor Author

ImYenil commented Mar 7, 2023

There should be an option to disable the 10 Hearts and only display the yellow numbers, please check the config before posting thing like this

Which options?

@porudev
Copy link

porudev commented Mar 7, 2023

There should be an option to disable the 10 Hearts and only display the yellow numbers, please check the config before posting thing like this

Which options?

image

Close this if this fix your issue

@ImYenil
Copy link
Contributor Author

ImYenil commented Mar 7, 2023

There should be an option to disable the 10 Hearts and only display the yellow numbers, please check the config before posting thing like this

Which options?

image

Close this if this fix your issue

But I want to display the health display like the picture I posted Even if I disale it, it won't show up as yellow numbers

@porudev
Copy link

porudev commented Mar 7, 2023

There should be an option to disable the 10 Hearts and only display the yellow numbers, please check the config before posting thing like this

Which options?

image
Close this if this fix your issue

But I want to display the health display like the picture I posted

have you tried disabling it?

@ImYenil
Copy link
Contributor Author

ImYenil commented Mar 7, 2023

There should be an option to disable the 10 Hearts and only display the yellow numbers, please check the config before posting thing like this

Which options?

image
Close this if this fix your issue

But I want to display the health display like the picture I posted

have you tried disabling it?

yes i tried

@Squesly
Copy link

Squesly commented Mar 7, 2023

There should be an option to disable the 10 Hearts and only display the yellow numbers, please check the config before posting thing like this

Which options?

image
Close this if this fix your issue

But I want to display the health display like the picture I posted

have you tried disabling it?

yes i tried

Yea Its disappear. No health
image

@ImYenil
Copy link
Contributor Author

ImYenil commented Mar 7, 2023

There should be an option to disable the 10 Hearts and only display the yellow numbers, please check the config before posting thing like this

Which options?

image
Close this if this fix your issue

But I want to display the health display like the picture I posted

have you tried disabling it?

yes i tried

Yea Its disappear. No health image

But I want to display yellow health numbers like the picture above?

@Squesly
Copy link

Squesly commented Mar 7, 2023

There should be an option to disable the 10 Hearts and only display the yellow numbers, please check the config before posting thing like this

Which options?

image
Close this if this fix your issue

But I want to display the health display like the picture I posted

have you tried disabling it?

yes i tried

Yea Its disappear. No health image

But I want to display yellow health numbers like the picture above?

Yea me too.

@porudev
Copy link

porudev commented Mar 7, 2023

There used to be yellow health numbers, i think it's because of the new SideBarLib

@tomkeuper
Copy link
Contributor

tomkeuper commented Mar 7, 2023

So if I understand correctly, you would want an option to switch between the health in numbers and the health bar as it is now?

image

@ImYenil
Copy link
Contributor Author

ImYenil commented Mar 7, 2023

So if I understand correctly, you would want an option to switch between the health in numbers and the health bar as it is now?

image

Yes

@WitheredWinter
Copy link

Actually,you guys can use TAB plugin to control tablist before Bedwars1058 add the feature.In TAB you can set the yellow num next to name to health,ping or any other placeholders.

@ImYenil
Copy link
Contributor Author

ImYenil commented Mar 7, 2023

Actually,you guys can use TAB plugin to control tablist before Bedwars1058 add the feature.In TAB you can set the yellow num next to name to health,ping or any other placeholders.

I hope this feature is added. without interacting with other plugins

@andrei1058
Copy link
Owner

so with the new sidebar you get heart icons instead of a number? what server version is that?

@ImYenil
Copy link
Contributor Author

ImYenil commented Mar 11, 2023

so with the new sidebar you get heart icons instead of a number? what server version is that?

Yes my server version 1.8.9

andrei1058 added a commit that referenced this issue Mar 11, 2023
@andrei1058 andrei1058 self-assigned this Mar 12, 2023
@tomkeuper
Copy link
Contributor

This is not fixed with the last commit.

@tomkeuper
Copy link
Contributor

The issue was not to show or not show the health of a player or above their head but the issue was to replace the hearts by the yellow value as seen in the first screenshot

andrei1058 added a commit that referenced this issue Mar 26, 2023

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
* Fix sidebar title animation not working #660

* Fixed wins placeholder not in lobby sidebar #658

* Fixed NPE when clicking outside of shop inventory #664

* Fixed command error when lobby location is not set

* Added unformatted player name to kill message and bed destroy

* Added Netherite armor to 1.16+ (#657)

* Added missing items in v1_12_R1

* Fixed level just showing numer (#661)

* expose sidebar on API

* a few updates (#632)

* Italian Language Update

* Fix Moneys reward team-support on Solo & update variables names

* add sidebar init event

* fix team identifier length (#682)

* Bug fixes and placeholder adjustments (#685)

read pr details

* fix no tab formatting for first player (#692)

* fix losing permanent items on rejoin (#385)

* fix scoreboard getting send twice (#690)

* fix void tp on newer servers

* fix swords disappearing (#686)

* fix invisibility potion compatibility with 1.8.8

* fix lobby tablist (#701)

* Add translation for Simplified Chinese (#628)

Co-authored-by: hugeBlack <wwkq03@outlook.com>
Co-authored-by: YukiEnd233 <85435560+YukiEnd233@users.noreply.github.com>

* Remove hand from hideArmor

* fix placeholders

* Fix elapsed time always null (#574)

* fix header and footer

* clean up

* should fix #699

* Remove Deprecation Warning for Version and Update getServerVersion Methods (#623)

* Remove Version Deprecation Warning

* update methods that use getServerVersion()

* Update Sidebar API link in README.md for new sidebar

* More ReadME changes

* Back to Java 11 and some clean up

* Mark PrePartyListener for removal

* Massive Clean up

* Improve TeamEliminatedEvent JavaDoc

* Updates

* fix #712
fix #681

* Add user texture to player head (#333)

* Add gamesPlayed placeholder

* Fixed placeholder typos

* remove unnecessary teams

* fix placeholder

completely fix #724

* fix player name invisible on 1.8

* removed replace gens with air (#529)

* add check if respawning (#732)

* Add catch for teleport exceptions

* Add global placeholders

* Add global placeholders to header and footer (#730)

* Add invis removed message

* fix papi support

* keep old placeholder at least for a few updates

* Bug fixes (#740)

* fix no tab formatting for first player (#692)

* fix losing permanent items on rejoin (#385)

* fix scoreboard getting send twice (#690)

* fix void tp on newer servers

* fix swords disappearing (#686)

* fix invisibility potion compatibility with 1.8.8

* fix lobby tablist (#701)

* Remove hand from hideArmor

* fix placeholders

* Fix elapsed time always null (#574)

* fix header and footer

* clean up

* should fix #699

* fix #712
fix #681

* Add user texture to player head (#333)

* Add gamesPlayed placeholder

* Fixed placeholder typos

* remove unnecessary teams

* fix placeholder

completely fix #724

* fix player name invisible on 1.8

* removed replace gens with air (#529)

* add check if respawning (#732)

* Add catch for teleport exceptions

* Add global placeholders

* Add global placeholders to header and footer (#730)

* Add invis removed message

* fix papi support

* keep old placeholder at least for a few updates

---------

Co-authored-by: Andrei Dascălu <andrew.dascalu@gmail.com>
Co-authored-by: andrei1058 <andrei7dascalu@gmail.com>

* clean up

* Internal Party Additions (Promote, list/info commands) (#715)

* getOwner and promote methods to Party interface

* Add /party promote command and English Lang

* Add /party info/list commands

* break;

* add Romanian Lang

* add Italian Lang

* add Other Lang

* clean up

* clean up

* clean up

* add missing messages

* do not break addons

---------

Co-authored-by: Andrei Dascălu <andrew.dascalu@gmail.com>

* Update Russian.java (#696)

update translations
Co-authored-by: Andrei Dascălu <andrew.dascalu@gmail.com>

* add missing return

---------

Co-authored-by: Tom Keuper <tomkeuper@live.nl>
Co-authored-by: Yuri <84080587+Xxyuri2005xX@users.noreply.github.com>
Co-authored-by: skbeh <60107333+skbeh@users.noreply.github.com>
Co-authored-by: hugeBlack <wwkq03@outlook.com>
Co-authored-by: YukiEnd233 <85435560+YukiEnd233@users.noreply.github.com>
Co-authored-by: J.T. McQuigg <J.T.McQuigg12@gmail.com>
Co-authored-by: Matveev_ <122512138+UnMatveev@users.noreply.github.com>
@ImYenil
Copy link
Contributor Author

ImYenil commented Mar 27, 2023

The issue was not to show or not show the health of a player or above their head but the issue was to replace the hearts by the yellow value as seen in the first screenshot

Is what I described added as it is?

andrei1058 added a commit that referenced this issue Nov 10, 2023

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
* Fix sidebar title animation not working #660

* Fixed wins placeholder not in lobby sidebar #658

* Fixed NPE when clicking outside of shop inventory #664

* Fixed command error when lobby location is not set

* Added unformatted player name to kill message and bed destroy

* Added Netherite armor to 1.16+ (#657)

* Added missing items in v1_12_R1

* Fixed level just showing numer (#661)

* expose sidebar on API

* a few updates (#632)

* Italian Language Update

* Fix Moneys reward team-support on Solo & update variables names

* add sidebar init event

* fix team identifier length (#682)

* Bug fixes and placeholder adjustments (#685)

read pr details

* fix no tab formatting for first player (#692)

* fix losing permanent items on rejoin (#385)

* fix scoreboard getting send twice (#690)

* fix void tp on newer servers

* fix swords disappearing (#686)

* fix invisibility potion compatibility with 1.8.8

* fix lobby tablist (#701)

* Add translation for Simplified Chinese (#628)

Co-authored-by: hugeBlack <wwkq03@outlook.com>
Co-authored-by: YukiEnd233 <85435560+YukiEnd233@users.noreply.github.com>

* Remove hand from hideArmor

* fix placeholders

* Fix elapsed time always null (#574)

* fix header and footer

* clean up

* should fix #699

* Remove Deprecation Warning for Version and Update getServerVersion Methods (#623)

* Remove Version Deprecation Warning

* update methods that use getServerVersion()

* Update Sidebar API link in README.md for new sidebar

* More ReadME changes

* Back to Java 11 and some clean up

* Mark PrePartyListener for removal

* Massive Clean up

* Improve TeamEliminatedEvent JavaDoc

* Updates

* fix #712
fix #681

* Add user texture to player head (#333)

* Add gamesPlayed placeholder

* Fixed placeholder typos

* remove unnecessary teams

* fix placeholder

completely fix #724

* fix player name invisible on 1.8

* removed replace gens with air (#529)

* add check if respawning (#732)

* Add catch for teleport exceptions

* Add global placeholders

* Add global placeholders to header and footer (#730)

* Add invis removed message

* fix papi support

* keep old placeholder at least for a few updates

* Bug fixes (#740)

* fix no tab formatting for first player (#692)

* fix losing permanent items on rejoin (#385)

* fix scoreboard getting send twice (#690)

* fix void tp on newer servers

* fix swords disappearing (#686)

* fix invisibility potion compatibility with 1.8.8

* fix lobby tablist (#701)

* Remove hand from hideArmor

* fix placeholders

* Fix elapsed time always null (#574)

* fix header and footer

* clean up

* should fix #699

* fix #712
fix #681

* Add user texture to player head (#333)

* Add gamesPlayed placeholder

* Fixed placeholder typos

* remove unnecessary teams

* fix placeholder

completely fix #724

* fix player name invisible on 1.8

* removed replace gens with air (#529)

* add check if respawning (#732)

* Add catch for teleport exceptions

* Add global placeholders

* Add global placeholders to header and footer (#730)

* Add invis removed message

* fix papi support

* keep old placeholder at least for a few updates

---------

Co-authored-by: Andrei Dascălu <andrew.dascalu@gmail.com>
Co-authored-by: andrei1058 <andrei7dascalu@gmail.com>

* clean up

* Internal Party Additions (Promote, list/info commands) (#715)

* getOwner and promote methods to Party interface

* Add /party promote command and English Lang

* Add /party info/list commands

* break;

* add Romanian Lang

* add Italian Lang

* add Other Lang

* clean up

* clean up

* clean up

* add missing messages

* do not break addons

---------

Co-authored-by: Andrei Dascălu <andrew.dascalu@gmail.com>

* Update Russian.java (#696)

update translations
Co-authored-by: Andrei Dascălu <andrew.dascalu@gmail.com>

* add missing return

* Fix #760 (#792)

* Added placeholders {team} and {teamColor} to display the player team and its corresponding colors on the teleporter (#796)

* Added placeholders for {team} and {teamColor} to display the player team and their corresponding colors on the teleporter

* Fixed an error in calculating the player teleporter gui size

* limit size to 54

---------

Co-authored-by: Andrei Dascălu <andrew.dascalu@gmail.com>

* Reduce some race conditions with IArena#getStatus (#775)

* Added support for 1.19_R3 (#761)

Co-authored-by: ItzCodex <tom183.private@gmail.com>

* Fix dropping and picking up items if main lobby is set on shared mode (#805)

* tag event handler

* fix drop/ pick up if main lobby is set on SHARED server type

* readme update (#811)

* Fixed bug where Dream Defender and Bed Bug were spawning at player's location instead of where they clicked. (#813)

Co-authored-by: PmzHeroV69 <pmzherov69@gmail.com>

* Add 1.20 support (#814)

* add 1.20 support

* mention jetbrains

* add new sidebar version that supports 1.20

* fix missing dependency on 1.17+ (#817)

* world restore adapters update (#820)

* world restore adapters update

* update workflow

* update workflow

* update workflow

* update workflow

* add missing dependency

* Glass protection barrier rework (#469)

* Add VersionSupport#calculateExplosionBlocks

* Add isGlass & isProtectedByGlass to VersionSupport

* isProtectedByGlass performs ray tracing to ensure there is no glass
  inbetween

* Change VersionSupport#calculateExplosionBlocks implementation

* Implement v1_8_R3#calculateExplosionBlocks

* Copied from net.minecraft.server.v1_8_R3.Explosion#a() (The NMS implementation of
  https://minecraft.fandom.com/wiki/Explosion#Model_of_block_destruction)

* Implement v1_9_R2#calculateExplosionBlocks

* Implement v1_10_R1#calculateExplosionBlocks

* Implement v1_11_R1#calculateExplosionBlocks

* Implement v1_12_R1#calculateExplosionBlocks

* Implement v1_13_R2#calculateExplosionBlocks

* Fix wrong behavior from locY in calculateExplosionBlocks

* Implement v1_14_R1#calculateExplosionBlocks

* Fix tnt breaking blocks under water @ 1.13

* Fix locY @ 1.12

* Fix blocks under water getting exploded

* Fix comments

* Implement v1_15_R1#calculateExplosionBlocks

* Implement v1_16_*#calculateExplosionBlocks

* Add exceptions for not implemented versions of calculateExplosionBlocks

* Change radius of explosion to float instead of int

* Reimplement explosive-related events to use NMS/better detection

* Add Config explosion-settings.explosion-size
* if size is set to auto OR any negative value it will cache the actual
  size of that entity, if it could not cache it (not found) then the
  default implementation is used (removing and protecting blocks)

* Fix location hashing rounding instead of flooring coords

* Add function caching to the default callback of calculateExplosionBlocks

* Add comment describing whatever this is

* Fix ExplosionPrimeEvent not being check correctly

* Fix distances being calculated wrong in VersionSupport#isProtectedByGlass

* Add BlockRay for better ray tracing

* Reimplement VersionSupport#isProtected and its events

* Fix typo

* Remove debug junk

* Add cache cleaning for BreakPlace

* test if block is placed in special cases

* Fix air being counted as a block

* Increase caching lifetime & change keys to Entity

* always manage explosions even if blockList is empty

* Fix imports

* Fix inaccurate calculation of the delta vector in BlockRay

* Add the 3 missing components to BlockRay

* wip

* wip

* implement explosion function

* improvements and clean up

* clean up

* clean up

* clean up

* fix typo

---------

Co-authored-by: Andrei Dascălu <andrew.dascalu@gmail.com>

* Fix default tower item (#831)

Fixed bug where wrong tower item was added as invalid material in shop.yml

* version string update

* change heal pool work (#832)

* change heal pool work

Since the upgrade price is likely to be different for each arena group, if the upgrade has a heal-pool in the name, it is changed to work

* Fix magic miner upgrade (#830)

* Fix magic miner upgrade

Fixed bug where magic miner upgrade was showing wrong material name in version 1.13 and above.

* Fix heal pool not working (#829)

Fixed bug preventing heal pool from working with wrong config path

* Fix sword upgrade (#828)

Fixed bug where upgrade-swords purchases in the upgrade shop didn't apply to axes

* fix missed implementation

* Fix Parties getParty with player UUID (#860)

* fix not loading (#875)

* Sidebar and Tab improvements, session stats remake (#845)

tab rework, sidebar imrovements, new top system and session statistics

* add 1.20 r2 support (#896)

* add 1.20 r2 support

* version string update

* Fix PAF Null issue (#853)

* Fix PAF Null issue

* Update Github actions

* Build 1.20 module against 1.20.1

* fix disablearena command (#839)

Changed this arena to not be disabled if a game is in progress

The reason for the change is that many errors occur when disableArena and enableArena. I will upload the file

* correct silverfish name (#840)

correct silverfish name

* Fix block protection (#841)

* Fix block protection

Fixed bug where shop protection and upgrades protection and generators protection did not work

* fix

fix

* SpoilPlayerTNTFeature code improvements (#892)

SpoilPlayerTNTFeature code improvements

---------

Co-authored-by: Tom Keuper <tomkeuper@live.nl>
Co-authored-by: Yuri <84080587+Xxyuri2005xX@users.noreply.github.com>
Co-authored-by: skbeh <60107333+skbeh@users.noreply.github.com>
Co-authored-by: hugeBlack <wwkq03@outlook.com>
Co-authored-by: YukiEnd233 <85435560+YukiEnd233@users.noreply.github.com>
Co-authored-by: J.T. McQuigg <J.T.McQuigg12@gmail.com>
Co-authored-by: Matveev_ <122512138+UnMatveev@users.noreply.github.com>
Co-authored-by: grass <68882326+Lsy-291@users.noreply.github.com>
Co-authored-by: Tom <72739475+Tom18314@users.noreply.github.com>
Co-authored-by: ItzCodex <tom183.private@gmail.com>
Co-authored-by: PmzHeroV69 <91284999+PmzHeroV69@users.noreply.github.com>
Co-authored-by: PmzHeroV69 <pmzherov69@gmail.com>
Co-authored-by: IIHERO4 <46909116+IIHERO4@users.noreply.github.com>
Co-authored-by: Yenil <85287520+ImYenil@users.noreply.github.com>
Co-authored-by: AlessioDP <alessiodptv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants