Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix include of remote style when there is only a local style #349

Merged
merged 6 commits into from
Apr 17, 2021
Merged

fix: Fix include of remote style when there is only a local style #349

merged 6 commits into from
Apr 17, 2021

Conversation

jaysonsantos
Copy link
Contributor

Proposed changes

This decreases the complexity when handling the urls and fix a problem when you have just a nitpick-style.toml which includes URLs.

Checklist

  • Read the contribution guidelines
  • Run make locally before pushing commits
  • Add tests for:
    • API
    • CLI
    • flake8 plugin (normal mode)
    • flake8 plugin (offline mode)
  • Write documentation when there's new API, functionality, etc.:
    • On README.md
    • On docs/*.rst files

@coveralls
Copy link

Pull Request Test Coverage Report for Build 758697703

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 96.303%
Totals Coverage Status
Change from base Build 757412345: -0.02%
Covered Lines: 1769
Relevant Lines: 1813
💛 - Coveralls

andreoliwa
andreoliwa approved these changes Apr 17, 2021
View reviewed changes
Copy link
Owner

@andreoliwa andreoliwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️ Thank you for fixing this edge case!

@andreoliwa andreoliwa merged commit 032855d into andreoliwa:develop Apr 17, 2021
@jaysonsantos jaysonsantos deleted the fix-remote-from-styles branch April 17, 2021 16:03
github-actions bot pushed a commit that referenced this pull request Jul 20, 2021
@semantic-release-bot
chore(release): 0.27.0 [skip ci]
f160fa1 
# [0.27.0](v0.26.0...v0.27.0) (2021-07-20)

### Bug Fixes

* **cli:** print "no violations" message ([2fedd0a](2fedd0a))
* **cli:** replace the "run" command by "fix" and "check" ([#359](#359)) ([34d2499](34d2499))
* don't fail when there is no config/root file ([#350](#350)) ([cca099a](cca099a))
* include of remote style when there is only a local style ([#349](#349)) ([032855d](032855d))
* run pre-commit hooks only on passed files ([#356](#356)) ([3db024a](3db024a))

### Features

* accept a regular GitHub URL as a style ([#361](#361)) ([8fc34cb](8fc34cb))
* enforce settings on any TOML file ([#352](#352)) ([8fd6324](8fd6324))
* fetch GitHub URLs directly ([#341](#341)) ([d3e6811](d3e6811))
* install on macOS with Homebrew ([c679adf](c679adf))
* pre-commit hook to apply changes ([#322](#322)) ([5e98e5f](5e98e5f))
* quick setup with `nitpick init` command ([#347](#347)) ([3156afe](3156afe))
* read configuration from `.nitpick.toml` or `pyproject.toml` ([#332](#332)) ([612ae41](612ae41))
* root files for other programming languages ([#321](#321)) ([09a0e83](09a0e83))
* support custom protocols for styles ([#333](#333)) ([9baef63](9baef63))
@github-actions
Copy link

🎉 This PR is included in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreoliwa andreoliwa andreoliwa approved these changes

Assignees
No one assigned
Labels
released Feature/fix is released
Projects
Nitpick Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaysonsantos @coveralls @andreoliwa