Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't abort when there is no config/root file #350

Merged
merged 4 commits into from
Apr 10, 2021
Merged

fix: don't abort when there is no config/root file #350

merged 4 commits into from
Apr 10, 2021

Conversation

andreoliwa
Copy link
Owner

@andreoliwa andreoliwa commented Apr 10, 2021 •
edited
Loading

Proposed changes

  • Fix error when no config file and no root file exist
  • Add nitpick-style.toml as a root file

Checklist

  • Read the contribution guidelines
  • Run make locally before pushing commits
  • Add tests for:
    • API
    • CLI
    • flake8 plugin (normal mode)
    • flake8 plugin (offline mode)
  • Write documentation when there's new API, functionality, etc.:
    • On README.md
    • On docs/*.rst files

@andreoliwa andreoliwa added the bug Something isn't working label Apr 10, 2021
@coveralls
Copy link

coveralls commented Apr 10, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 734875157

  • 19 of 19 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 96.274%
Totals Coverage Status
Change from base Build 734611712: 0.3%
Covered Lines: 1775
Relevant Lines: 1820
💛 - Coveralls

@andreoliwa andreoliwa enabled auto-merge (squash) April 10, 2021 01:37
@andreoliwa andreoliwa merged commit cca099a into develop Apr 10, 2021
@andreoliwa andreoliwa deleted the no-root-error branch April 10, 2021 01:39
github-actions bot pushed a commit that referenced this pull request Jul 20, 2021
@semantic-release-bot
chore(release): 0.27.0 [skip ci]
f160fa1 
# [0.27.0](v0.26.0...v0.27.0) (2021-07-20)

### Bug Fixes

* **cli:** print "no violations" message ([2fedd0a](2fedd0a))
* **cli:** replace the "run" command by "fix" and "check" ([#359](#359)) ([34d2499](34d2499))
* don't fail when there is no config/root file ([#350](#350)) ([cca099a](cca099a))
* include of remote style when there is only a local style ([#349](#349)) ([032855d](032855d))
* run pre-commit hooks only on passed files ([#356](#356)) ([3db024a](3db024a))

### Features

* accept a regular GitHub URL as a style ([#361](#361)) ([8fc34cb](8fc34cb))
* enforce settings on any TOML file ([#352](#352)) ([8fd6324](8fd6324))
* fetch GitHub URLs directly ([#341](#341)) ([d3e6811](d3e6811))
* install on macOS with Homebrew ([c679adf](c679adf))
* pre-commit hook to apply changes ([#322](#322)) ([5e98e5f](5e98e5f))
* quick setup with `nitpick init` command ([#347](#347)) ([3156afe](3156afe))
* read configuration from `.nitpick.toml` or `pyproject.toml` ([#332](#332)) ([612ae41](612ae41))
* root files for other programming languages ([#321](#321)) ([09a0e83](09a0e83))
* support custom protocols for styles ([#333](#333)) ([9baef63](9baef63))
@github-actions
Copy link

🎉 This PR is included in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working released Feature/fix is released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreoliwa @coveralls