Skip to content

Merge pull request #20 from Overcastan/andrew-update-winterfell #76

Merge pull request #20 from Overcastan/andrew-update-winterfell

Merge pull request #20 from Overcastan/andrew-update-winterfell #76

GitHub Actions / clippy succeeded Feb 14, 2024 in 0s

clippy

14 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 14
Note 0
Help 0

Versions

  • rustc 1.78.0-nightly (a84bb95a1 2024-02-13)
  • cargo 1.78.0-nightly (fc1d58fd0 2024-02-09)
  • clippy 0.1.78 (a84bb95 2024-02-13)

Annotations

Check warning on line 57 in src/stark.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified

warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified
  --> src/stark.rs:57:5
   |
57 |     async fn prove(
   |     ^^^^^
   |
   = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future`
   = note: `#[warn(async_fn_in_trait)]` on by default
help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change
   |
57 ~     fn prove(
58 |         &self,
59 |         options: ProofOptions,
60 |         witness: Self::Witness,
61 ~     ) -> impl std::future::Future<Output = Result<Proof<Self>, ProvingError>> + Send {async {
62 |         default_prove(self, options, witness)
63 ~     } }
   |

Check warning on line 183 in src/prover.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
   --> src/prover.rs:183:28
    |
183 | /// Bit reverses the first ce_domain_size many values of the matrix columns.
    |                            ^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
note: the lint level is defined here
   --> src/lib.rs:1:22
    |
1   | #![warn(clippy::all, clippy::pedantic, clippy::cargo, clippy::nursery)]
    |                      ^^^^^^^^^^^^^^^^
    = note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]`
help: try
    |
183 | /// Bit reverses the first `ce_domain_size` many values of the matrix columns.
    |                            ~~~~~~~~~~~~~~~~

Check warning on line 70 in src/eval_cpu.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unreachable pattern

warning: unreachable pattern
  --> src/eval_cpu.rs:70:9
   |
70 |         _ => unreachable!(),
   |         ^
   |
   = note: `#[warn(unreachable_patterns)]` on by default

Check warning on line 28 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the feature `return_position_impl_trait_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable

warning: the feature `return_position_impl_trait_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable
  --> src/lib.rs:28:5
   |
28 |     return_position_impl_trait_in_trait,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 23 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the feature `async_fn_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable

warning: the feature `async_fn_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable
  --> src/lib.rs:23:5
   |
23 |     async_fn_in_trait,
   |     ^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(stable_features)]` on by default

Check warning on line 293 in examples/rescue/rescue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> examples/rescue/rescue.rs:293:50
    |
293 | fn matrix_mul<F: PrimeField>(a: &Vec<Vec<F>>, b: &Vec<Vec<F>>) -> Vec<Vec<F>> {
    |                                                  ^^^^^^^^^^^^ help: change this to: `&[Vec<F>]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

Check warning on line 293 in examples/rescue/rescue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> examples/rescue/rescue.rs:293:33
    |
293 | fn matrix_mul<F: PrimeField>(a: &Vec<Vec<F>>, b: &Vec<Vec<F>>) -> Vec<Vec<F>> {
    |                                 ^^^^^^^^^^^^ help: change this to: `&[Vec<F>]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

Check warning on line 272 in examples/rescue/rescue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> examples/rescue/rescue.rs:272:44
    |
272 | fn transpose<T: Clone + Copy + Default>(m: &Vec<Vec<T>>) -> Vec<Vec<T>> {
    |                                            ^^^^^^^^^^^^ help: change this to: `&[Vec<T>]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

Check warning on line 219 in examples/rescue/rescue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> examples/rescue/rescue.rs:219:30
    |
219 | fn echelon_form<T: Field>(m: &Vec<Vec<T>>) -> Vec<Vec<T>> {
    |                              ^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `#[warn(clippy::ptr_arg)]` on by default
help: change this to
    |
219 ~ fn echelon_form<T: Field>(m: &[Vec<T>]) -> Vec<Vec<T>> {
220 |     if m.is_empty() || m[0].is_empty() {
  ...
227 |     let mut lead = 0;
228 ~     let mut m = m.to_owned();
    |

Check warning on line 57 in src/stark.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified

warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified
  --> src/stark.rs:57:5
   |
57 |     async fn prove(
   |     ^^^^^
   |
   = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future`
   = note: `#[warn(async_fn_in_trait)]` on by default
help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change
   |
57 ~     fn prove(
58 |         &self,
59 |         options: ProofOptions,
60 |         witness: Self::Witness,
61 ~     ) -> impl std::future::Future<Output = Result<Proof<Self>, ProvingError>> + Send {async {
62 |         default_prove(self, options, witness)
63 ~     } }
   |

Check warning on line 183 in src/prover.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
   --> src/prover.rs:183:28
    |
183 | /// Bit reverses the first ce_domain_size many values of the matrix columns.
    |                            ^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
note: the lint level is defined here
   --> src/lib.rs:1:22
    |
1   | #![warn(clippy::all, clippy::pedantic, clippy::cargo, clippy::nursery)]
    |                      ^^^^^^^^^^^^^^^^
    = note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]`
help: try
    |
183 | /// Bit reverses the first `ce_domain_size` many values of the matrix columns.
    |                            ~~~~~~~~~~~~~~~~

Check warning on line 70 in src/eval_cpu.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unreachable pattern

warning: unreachable pattern
  --> src/eval_cpu.rs:70:9
   |
70 |         _ => unreachable!(),
   |         ^
   |
   = note: `#[warn(unreachable_patterns)]` on by default

Check warning on line 28 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the feature `return_position_impl_trait_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable

warning: the feature `return_position_impl_trait_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable
  --> src/lib.rs:28:5
   |
28 |     return_position_impl_trait_in_trait,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 23 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the feature `async_fn_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable

warning: the feature `async_fn_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable
  --> src/lib.rs:23:5
   |
23 |     async_fn_in_trait,
   |     ^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(stable_features)]` on by default