Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aioredis has been migrated into redis-py and effectively discontinued. #215

Closed
aabrodskiy opened this issue Jul 20, 2022 · 5 comments · Fixed by #217
Closed

aioredis has been migrated into redis-py and effectively discontinued. #215

aabrodskiy opened this issue Jul 20, 2022 · 5 comments · Fixed by #217
Labels
breaking Breaking Changes bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@aabrodskiy
Copy link

There are asyncio handling issues in aioredis (e.g. using get_event_loop instead of get_running_loop), which are causing issues to pydantic-aioredis when working with async and sync processess.
Here is the description : issue 1273
As I understood from mainterners of aioredis, they have migrated the code into redis-py, which is maintained by RedisLabs, founders of Redis.
I've verified and the async redis client is already in the latest version of redis-py and I get a feeling that aioredis is discontinued.
From my quick assessment, it would be a fairly limited change in the store.py module to move to redis-py or to support externally assigned redis_store in the init.
Apologies again, I would be happy to propose a PR but just don't know how.

@aabrodskiy
Copy link
Author

aabrodskiy commented Jul 20, 2022

here is the announcement: https://github.com/aio-libs/aioredis-py

📢🚨 Aioredis is now in redis-py 4.2.0rc1+ 🚨🚨
Aioredis is now in redis-py 4.2.0rc1+

To install, just do pip install redis>=4.2.0rc1. The code is almost the exact same. You will just need to import like so:

from redis import asyncio as aioredis
This way you don't have to change all your code, just the imports.

https://github.com/redis/redis-py/releases/tag/v4.2.0rc1

Now that aioredis is under Redis officially, I hope there will never be an unmaintained, asyncio Redis lib in the Python ecosystem again. I will be helping out maintenance at Redis-py for the foreseeable future just to get some of the asyncio stuff out of the way. There are also some bugs that didn't make it into the redis/redis-py#1899 that I'll be slowly migrating over throughout the next few weeks -- so long as my exams don't kill me beforehand :)

Thank you all so much for your commitment to this repository! Thank you so much to @abrookins @seandstewart @bmerry for all the commits and maintenance. And thank you to everyone here who has been adopting the new code base and squashing bugs. It's been an honor!

Cheers, Andrew

@andrewthetechie
Copy link
Owner

Thanks for reporting this @aabrodskiy.

I'll make sure to watch redis-py and once the 4.2.0 release is ready (out of release candidate status), I'll look at making the switch

@andrewthetechie andrewthetechie added bug Something isn't working breaking Breaking Changes dependencies Pull requests that update a dependency file labels Jul 21, 2022
andrewthetechie added a commit that referenced this issue Jul 21, 2022
Fixes #215

aioredis-py has been migrated into redis-py as of the 4.2.0 release
line.

This replaces aioredis-py with redis-py ^4.34.0
@andrewthetechie
Copy link
Owner

Turns out, redis-py has merged the aio implementation into a full release, and had a point release beyond it.

Working on moving to redis-py in #217

andrewthetechie added a commit that referenced this issue Jul 21, 2022
Fixes #215

aioredis-py has been migrated into redis-py as of the 4.2.0 release
line.

This replaces aioredis-py with redis-py ^4.34.0
andrewthetechie added a commit that referenced this issue Jul 21, 2022
Fixes #215

aioredis-py has been migrated into redis-py as of the 4.2.0 release
line.

This replaces aioredis-py with redis-py ^4.34.0
andrewthetechie added a commit that referenced this issue Jul 21, 2022
* feat: move to redis-py

Fixes #215

aioredis-py has been migrated into redis-py as of the 4.2.0 release
line.

This replaces aioredis-py with redis-py ^4.34.0

* docs: update README with redis-py dependency
@andrewthetechie
Copy link
Owner

The move to redis-py is part of #221

This will be v0.7.0.

@andrewthetechie
Copy link
Owner

https://github.com/andrewthetechie/pydantic-aioredis/releases/tag/v0.7.0

Released and available on pypi. Let me know if this doesn't fix your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants