-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup after spotless update #513
Conversation
@@ -34,7 +34,7 @@ subprojects { | |||
targetExclude("$buildDir/**/*.kt") | |||
targetExclude("bin/**/*.kt") | |||
|
|||
ktlint(libs.versions.ktlint.get()).userData(["max_line_length" : "100"]) | |||
ktlint(libs.versions.ktlint.get()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this the syntax to override it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, not now results in https://github.com/android/wear-os-samples/runs/7776351662?check_suite_focus=true
UserData should not contain '.editorconfig' properties [max_line_length]. Such properties should be passed via the 'ExperimentalParams.editorConfigOverride' field. Note that this is only required for properties that (potentially) contain a value that differs from the actual value in the '.editorconfig' file.
@@ -63,7 +63,7 @@ fun ControlDashboard( | |||
circle = circle, | |||
mic = mic, | |||
play = play, | |||
music = music, | |||
music = music |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allow trailing comma was set to true for this sample, so how come it stripped it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can flip to false in .editorconfig so it's consistent. I'm about to go on holidays, so would like build green and passing and then forget about this :)
Or we can raise a bug, similar reports diffplug/spotless#1193 and it's defined here and one more place https://github.com/pinterest/ktlint/blob/d64733ba1711c592fb78fe04d3472c5294004450/ktlint-ruleset-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/TrailingCommaOnCallSiteRule.kt#L290
Landing since, the build is broken anyway. |
With the compose update we started getting this #507
And pulling that thread we end up having to accept a bunch of new rules for ktlint, and spotless. This is an example fixing up a PR using
./gradlew spotlessApply
and fixing up issues.