Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RTSP Mp4a-Latm #162

Closed
wants to merge 11 commits into from
Closed

Add support for RTSP Mp4a-Latm #162

wants to merge 11 commits into from

Conversation

rakeshnitb
Copy link
Contributor

Added Mp4a-latm RTP Packet reader and added support for Mp4a-latm
playback through RTSP.

Change-Id: Ia590393f53ca880af926907843f6bea9ff0f4b35

@rakeshnitb
Add support for RTSP Mp4a-Latm
048aaf3 
Added Mp4a-latm RTP Packet reader and added support for Mp4a-latm
playback through RTSP.

Change-Id: Ia590393f53ca880af926907843f6bea9ff0f4b35
@claincly claincly self-assigned this Sep 5, 2022
claincly
claincly requested changes Sep 5, 2022
View reviewed changes
...exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aPayloadReader.java Outdated Show resolved Hide resolved
...exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aPayloadReader.java Outdated Show resolved Hide resolved
...exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aPayloadReader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Show resolved Hide resolved
...exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aPayloadReader.java Outdated Show resolved Hide resolved
...exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aPayloadReader.java Outdated Show resolved Hide resolved
...exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aPayloadReader.java Outdated Show resolved Hide resolved
...exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aPayloadReader.java Outdated Show resolved Hide resolved
...exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aPayloadReader.java Outdated Show resolved Hide resolved
@rakeshnitb
Fix review comment in RTP Mp4a-latm Reader
9648529 
Change-Id: I7c5c12d86589bdc3f88c336573759bcfb0e7ce1b
@rakeshnitb
Added Rtp Mp4a-Latm Reader Test
15f9655 
Change-Id: I0054e54183df0bb9370bf3fe7047076e285e1e8f
claincly
claincly reviewed Sep 15, 2022
View reviewed changes
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Show resolved Hide resolved
...exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aPayloadReader.java Outdated Show resolved Hide resolved
@rakeshnitb @umangsaini
Added support for CSD parsing in RTSP Mp4a-Latm Reader
97afe69 
Added support for parsing CSD data to get sample Rate and Channel
Count.

Change-Id: I69fb0fa2cb11453d3b9e416925d3776eb6dc19a3
claincly
claincly requested changes Sep 27, 2022
View reviewed changes
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReader.java Outdated Show resolved Hide resolved
...exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aPayloadReader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReader.java Outdated Show resolved Hide resolved
@rakeshnitb
Fix some more review comment in RTP Mp4a-Latm Reader
4880057 
Change-Id: I9033d0bd93c6129c64c41ce70fef26bf8a6e4b6e
@rakeshnitb
Fix review comment in CSD parsing of Mp4a-Latm Reader
9f8d699 
Change-Id: I6fc07d88a7dbc52fc2fbe0e5ad45a53f8f25c4fd
claincly
claincly requested changes Sep 30, 2022
View reviewed changes
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReader.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java Outdated Show resolved Hide resolved
@rakeshnitb
Fix review comment in mp4a-latm Reader
0ac84fe 
Change-Id: I004f4a9ed9bd7cc48708d82a01c945789d1e9e5e
@rakeshnitb
Fix review comment in CSD parsing of Mp4a-Latm
ce98d6d 
Change-Id: I70c412870952e18826f43d218b074b2829127e10
@rakeshnitb
Fix review comment in mp4a-latm Reader
ca5bab5 
Change-Id: I325a0ee1f6027f0f63233025d3357c1dc794b2ac
@rakeshnitb
Fix review comment in Mp4a-Latm reader
cee05d3 
Moved getNumOfSubframesFromMpeg4AudioConfig() function call inside
constructor.

Change-Id: If952ea641327dcfe10de50094ca35f3baae985de
claincly
claincly requested changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@claincly claincly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be more thorough with the code??

...es/exoplayer_rtsp/src/test/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReaderTest.java Outdated Show resolved Hide resolved
...es/exoplayer_rtsp/src/test/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReaderTest.java Outdated Show resolved Hide resolved
...es/exoplayer_rtsp/src/test/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReaderTest.java Outdated Show resolved Hide resolved
...es/exoplayer_rtsp/src/test/java/androidx/media3/exoplayer/rtsp/reader/RtpMp4aReaderTest.java Outdated Show resolved Hide resolved
@rakeshnitb
Fix review comments in mp4a-latm reader and test
a89ed98 
Fix review comment in Mp4a-Latm csd parsing and Mp4a-Latm reader test.

Change-Id: Idf8e45b9e4f6f9a08277d7c0ec2cae65d7025414
rohitjoins added a commit that referenced this pull request Oct 24, 2022
@rohitjoins
Merge pull request #162 from ittiam-systems:rtp-mp4a-latm
d21c948 
PiperOrigin-RevId: 482490230
@umangsaini
Copy link

This CL has merged. The Pull request may be marked as completed.

@claincly claincly closed this Nov 4, 2022
microkatz pushed a commit that referenced this pull request Nov 22, 2022
@rohitjoins @microkatz
Merge pull request #162 from ittiam-systems:rtp-mp4a-latm
a2096b6 
PiperOrigin-RevId: 482490230
(cherry picked from commit d21c948)
icbaker pushed a commit that referenced this pull request Nov 24, 2022
@rohitjoins
Merge pull request #162 from ittiam-systems:rtp-mp4a-latm
fd2ba37 
PiperOrigin-RevId: 482490230
icbaker pushed a commit that referenced this pull request Dec 12, 2022
@rohitjoins @microkatz
Merge pull request #162 from ittiam-systems:rtp-mp4a-latm
23b070d 
PiperOrigin-RevId: 482490230
(cherry picked from commit fd2ba37)
@androidx androidx locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@claincly claincly claincly requested changes

@harishdm harishdm harishdm left review comments

Assignees

@rakeshnitb rakeshnitb

@claincly claincly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rakeshnitb @umangsaini @harishdm @claincly