Grid tweaks #114
Closed
Grid tweaks #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds .grid-flex-cell-centered class
wraithgar
commented
Mar 12, 2018
| @@ -418,24 +417,21 @@ dl dd { | |||
| } | |||
| [class^="grid-flex-cell"], | |||
| [class*=" grid-flex-cell"] { | |||
| -webkit-flex: 0 0 100%; | |||
| -ms-flex: 0 0 100%; | |||
| flex: 0 0 100%; | |||
There was a problem hiding this comment.
I don't know why the rebuild removed these.
There was a problem hiding this comment.
It has only removed -webkit-flex the rest are still there in the result.
Autoprefixer stays up to date with which prefixes are required. As of today I'm guessing -webkit-flex is redundant as almost all webkits in the wild will support flex. So overtime, rebuilding exactly the same source should see fewer prefixes added.
Merged
|
Merged into this new PR: #118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
.grid-flex-cell-centeredto the grid system.It would not be terribly difficult to add
2of3,2of4and3of4which would round out the "of" classes in my opinion, but I don't know if that's useful or not. In one of my personal projects I also added anof5subset that was helpful on wider views but I can see how that is going down a path of which it is hard to determine the end.