-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add merge and friends with arbitrary number of args #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent - this is a great idea. Thanks for the contribution.
I think we should address Julia 1.0 compatibility (either drop it, or maintain it) and remove the Callable
constraint, but other than that it looks good to me.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 79.35% 80.10% +0.74%
==========================================
Files 21 20 -1
Lines 2349 2357 +8
==========================================
+ Hits 1864 1888 +24
+ Misses 485 469 -16 ☔ View full report in Codecov by Sentry. |
Thanks for the quick reply and review! |
Re Julia 1.6, the question I have is this a breaking change? Do we need a major version bump? I suppose the package manager will deal with it for us. |
Nope, it's not a breaking change (with the last commit). It can be argued that it is a bugfix (so bugfix release), since it just makes merge and co on AbstractDictionaries compliant with the API defined by Julia for AbstractDict. |
Sorry, my comment was about changing the minimum compatible Julia version to 1.6. In any case, such a decision can be dealt with seperately. (I agree this is more of a bugfix). Thanks again! |
Closes #129
adds methods for
merge
,merge!
,mergewith
andmergewith!
with arbitrary number ofAbstractDictionary
args.