Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy indices #136

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Copy indices #136

merged 5 commits into from
Jan 30, 2024

Conversation

andyferris
Copy link
Owner

@andyferris andyferris commented Jan 30, 2024

Fixes #98. Subsumes #101.

I've also removed any guff that was there to support Julia versions less than 1.6.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (259a3f0) 80.23% compared to head (524f1a8) 80.48%.

Files Patch % Lines
src/map.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   80.23%   80.48%   +0.24%     
==========================================
  Files          21       21              
  Lines        2363     2357       -6     
==========================================
+ Hits         1896     1897       +1     
+ Misses        467      460       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyferris
Copy link
Owner Author

Since this is a breaking change, I'll need to tag a minor release instead of a patch (we are still version 0.x)

@andyferris andyferris merged commit 544201c into master Jan 30, 2024
18 checks passed
@andyferris andyferris deleted the copy-indices branch January 30, 2024 13:16
@mtfishman
Copy link
Contributor

Thanks @andyferris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set! is not copy safe
2 participants