Fix nested arrays support #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix_nested_arrays_support
branch
2 times, most recently
from
38d04e3
to
c1b53dc
Compare
deivid-rodriguez
force-pushed
the
fix_nested_arrays_support
branch
from
c1b53dc
to
7d0a807
Compare
deivid-rodriguez
force-pushed
the
fix_nested_arrays_support
branch
from
7d0a807
to
2e40312
Compare
|
Hi @andypike, I see that |
|
Five months later, another ping! @andypike What can we do to move this forward? |
andypike
approved these changes
Oct 16, 2018
|
Wowowwwww, thanks @andypike!! 🎉 🎉 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for Rectify!
I have the classical nested form in my app. A survey has many questions, and a question has many answers. I manage survey creation on a single form. However, I found that
rectifydoes not support this case out of the box. This PR implements support for that, not sure if it's the right way to do it but it seems to work for me.NOTE: Sorry about the unrelated changes but the dependencies were quite outdated so the tests wouldn't pass on my system without doing some mantainance.
NOTE2: Also added some changes to shush codeclimate, let me know if you want to handle that in a separate PR or whatever.