Change filepaths for bootstrap #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap as dependency
Removed comma
Another comma
Correct path to bootstrap scss
Update master
Change filepath to import with ~
|
I was busy and didn't have time to check your PR until now. Sorry about that. Will test it this week and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the filepaths for bootstrap so when someone needs to compile the sass in their own way, it doesn't throw any errors because the bootstrap files don't exists.
Grunt doesn't know the '~' function for looking in the node_modules folder by default, so added the needed extensions in the grunt file for compiling with grunt.