Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java8 #63

Closed
angelozerr opened this issue Jul 15, 2016 · 8 comments
Closed

Use Java8 #63

angelozerr opened this issue Jul 15, 2016 · 8 comments
Milestone

Comments

@angelozerr
Copy link
Owner

I would like to use https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CompletableFuture.html (which requires Java8) instead of using collector (seehttps://github.com/angelozerr/typescript.java/blob/master/core/ts.core/src/ts/client/TypeScriptServiceClient.java#L169)

It means that Java8 is required. Since Neon requires Java8, I think we can have Java8 depdendency.

@piotrtomiak are you OK with that?

@piotrtomiak
Copy link
Contributor

@angelozerr - sure

@hdave
Copy link

hdave commented Sep 2, 2016

Yes - not a problem.

@cm325
Copy link

cm325 commented Sep 13, 2016

Great to hear, so does this mean this plugin works now with java 8 on eclipse neon?

@angelozerr
Copy link
Owner Author

@cm325 typescript.java 1.0.0 (and perhaps 1.1.0) is based on Java6 and not linked to Neon (just for tsconfig.json editor)

But I would like to use Java8 CompletableFuture. I have created this issue to know if use of Neon + Java8 is OK for typescript.java users.

@cm325
Copy link

cm325 commented Sep 13, 2016

Ok... so, can I install this on Neon and will it work if eclipse is setup
to use a java 8 jdk?

On Tue, Sep 13, 2016 at 5:19 PM, Angelo [email protected] wrote:

@cm325 https://github.com/cm325 typescript.java 1.0.0 (and perhaps
1.1.0) is based on Java6 and not linked to Neon (just for tsconfig.json
editor)

But I would like to use Java8 CompletableFuture. I have created this issue
to know if use of Neon + Java8 is OK for typescript.java users.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#63 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABaeDQZfM-Q6m53eTQqi2T6fOymQ23f6ks5qpxNmgaJpZM4JNeTu
.

@angelozerr
Copy link
Owner Author

typescript.java works with Neon. If you wish to use Neon you will need Java8.

@cm325
Copy link

cm325 commented Sep 14, 2016

great, thanks!

On Wed, Sep 14, 2016 at 3:27 AM, Angelo [email protected] wrote:

typescript.java works with Neon. If you wish to use Neon you will need
Java8.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#63 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABaeDSdAfKXYDc9vJCYkJgR75bHyHdxjks5qp6HOgaJpZM4JNeTu
.

angelozerr added a commit that referenced this issue Jan 6, 2017
angelozerr added a commit that referenced this issue Jan 7, 2017
angelozerr added a commit that referenced this issue Jan 7, 2017
angelozerr added a commit that referenced this issue Jan 7, 2017
angelozerr added a commit that referenced this issue Jan 8, 2017
angelozerr added a commit that referenced this issue Jan 9, 2017
angelozerr added a commit that referenced this issue Jan 9, 2017
angelozerr added a commit that referenced this issue Jan 9, 2017
@angelozerr angelozerr added this to the 1.2.0 milestone Jan 9, 2017
angelozerr added a commit that referenced this issue Jan 9, 2017
angelozerr added a commit to angelozerr/angular-eclipse that referenced this issue Jan 9, 2017
angelozerr added a commit that referenced this issue Jan 9, 2017
angelozerr added a commit to angelozerr/angular-eclipse that referenced this issue Jan 9, 2017
@angelozerr
Copy link
Owner Author

@boniatillo-com just for your information, now I have a clean API with Java8 CompletableFuture. See https://github.com/angelozerr/typescript.java/blob/master/core/ts.core/src/ts/client/ITypeScriptServiceClient.java

CDMiXer added a commit to CDMiXer/Woolloomooloo that referenced this issue Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants