feat(@ngtools/webpack): redirect ngcc errors and warnings to webpack

angular · Apr 5, 2019 · 801f667 · 801f667
1 parent f9b4bdf
commit 801f667
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/packages/ngtools/webpack/src/angular_compiler_plugin.ts b/packages/ngtools/webpack/src/angular_compiler_plugin.ts
@@ -679,6 +679,8 @@ export class AngularCompilerPlugin {
             ngcc,
             this._mainFields,
             compilerWithFileSystems.inputFileSystem,
+            this._warnings,
+            this._errors,
           );
         }
       }

diff --git a/packages/ngtools/webpack/src/ngcc_processor.ts b/packages/ngtools/webpack/src/ngcc_processor.ts
@@ -6,6 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+import { Logger } from '@angular/compiler-cli/ngcc';
 import * as ts from 'typescript';
 import { InputFileSystem } from 'webpack';
 import { time, timeEnd } from './benchmark';
@@ -24,11 +25,16 @@ import { workaroundResolve } from './utils';
 export class NgccProcessor {
   private _processedModules = new Set<string>();
 
+  private _logger: NgccLogger;
+
   constructor(
     private readonly ngcc: typeof import('@angular/compiler-cli/ngcc'),
     private readonly propertiesToConsider: string[],
     private readonly inputFileSystem: InputFileSystem,
+    private readonly compilationWarnings: (Error | string)[],
+    private readonly compilationErrors: (Error | string)[],
   ) {
+    this._logger = new NgccLogger(this.compilationWarnings, this.compilationErrors);
   }
 
   processModule(
@@ -61,6 +67,7 @@ export class NgccProcessor {
       propertiesToConsider: this.propertiesToConsider,
       compileAllFormats: false,
       createNewEntryPointFormats: true,
+      logger: this._logger,
     });
     timeEnd(timeLabel);
 
@@ -95,3 +102,23 @@ export class NgccProcessor {
     }
   }
 }
+
+class NgccLogger implements Logger {
+  constructor(
+    private readonly compilationWarnings: (Error | string)[],
+    private readonly compilationErrors: (Error | string)[],
+  ) {
+  }
+
+  debug(..._args: string[]) { }
+
+  info(..._args: string[]) { }
+
+  warn(...args: string[]) {
+    this.compilationWarnings.push(args.join(' '));
+  }
+
+  error(...args: string[]) {
+    this.compilationErrors.push(new Error(args.join(' ')));
+  }
+}