fix(@angular-devkit/build-angular): extractLicenses didn't have an …

…effect when using server builder
angular · Jul 12, 2021 · 9a04975 · 9a04975
1 parent 54c170b
commit 9a04975
Show file tree

Hide file tree

Showing 4 changed files with 62 additions and 16 deletions.
diff --git a/packages/angular_devkit/build_angular/src/server/tests/options/extract-licenses_spec.ts b/packages/angular_devkit/build_angular/src/server/tests/options/extract-licenses_spec.ts
@@ -0,0 +1,46 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+import { execute } from '../../index';
+import { BASE_OPTIONS, SERVER_BUILDER_INFO, describeBuilder } from '../setup';
+
+describeBuilder(execute, SERVER_BUILDER_INFO, (harness) => {
+  describe('Option: "extractLicenses"', () => {
+    it(`should generate '3rdpartylicenses.txt' when 'extractLicenses' is true`, async () => {
+      harness.useTarget('server', {
+        ...BASE_OPTIONS,
+        extractLicenses: true,
+      });
+
+      const { result } = await harness.executeOnce();
+      expect(result?.success).toBe(true);
+      harness.expectFile('dist/3rdpartylicenses.txt').content.toContain('MIT');
+    });
+
+    it(`should not generate '3rdpartylicenses.txt' when 'extractLicenses' is false`, async () => {
+      harness.useTarget('server', {
+        ...BASE_OPTIONS,
+        extractLicenses: false,
+      });
+
+      const { result } = await harness.executeOnce();
+      expect(result?.success).toBe(true);
+      harness.expectFile('dist/3rdpartylicenses.txt').toNotExist();
+    });
+
+    it(`should generate '3rdpartylicenses.txt' when 'extractLicenses' is not set`, async () => {
+      harness.useTarget('server', {
+        ...BASE_OPTIONS,
+      });
+
+      const { result } = await harness.executeOnce();
+      expect(result?.success).toBe(true);
+      harness.expectFile('dist/3rdpartylicenses.txt').content.toContain('MIT');
+    });
+  });
+});
diff --git a/packages/angular_devkit/build_angular/src/server/tests/options/source-map_spec.ts b/packages/angular_devkit/build_angular/src/server/tests/options/source-map_spec.ts
@@ -133,7 +133,7 @@ describeBuilder(execute, SERVER_BUILDER_INFO, (harness) => {
       harness.expectFile('dist/main.js').content.not.toContain('sourceMappingURL=main.js.map');
     });
 
-    it(`should not generate scripts sourceMaps when "scripts" option is true`, async () => {
+    it(`should generate scripts sourceMaps when "scripts" option is true`, async () => {
       harness.useTarget('server', {
         ...BASE_OPTIONS,
         sourceMap: {

diff --git a/packages/angular_devkit/build_angular/src/webpack/configs/browser.ts b/packages/angular_devkit/build_angular/src/webpack/configs/browser.ts
@@ -41,21 +41,6 @@ export function getBrowserConfig(wco: WebpackConfigOptions): webpack.Configurati
     );
   }
 
-  if (extractLicenses) {
-    const LicenseWebpackPlugin = require('license-webpack-plugin').LicenseWebpackPlugin;
-    extraPlugins.push(
-      new LicenseWebpackPlugin({
-        stats: {
-          warnings: false,
-          errors: false,
-        },
-        perChunkOutput: false,
-        outputFilename: '3rdpartylicenses.txt',
-        skipChildCompilers: true,
-      }),
-    );
-  }
-
   if (scriptsSourceMap || stylesSourceMap) {
     extraPlugins.push(
       getSourceMapDevTool(

diff --git a/packages/angular_devkit/build_angular/src/webpack/configs/common.ts b/packages/angular_devkit/build_angular/src/webpack/configs/common.ts
@@ -263,6 +263,21 @@ export function getCommonConfig(wco: WebpackConfigOptions): Configuration {
     );
   }
 
+  if (buildOptions.extractLicenses) {
+    const LicenseWebpackPlugin = require('license-webpack-plugin').LicenseWebpackPlugin;
+    extraPlugins.push(
+      new LicenseWebpackPlugin({
+        stats: {
+          warnings: false,
+          errors: false,
+        },
+        perChunkOutput: false,
+        outputFilename: '3rdpartylicenses.txt',
+        skipChildCompilers: true,
+      }),
+    );
+  }
+
   if (buildOptions.statsJson) {
     extraPlugins.push(
       new (class {