Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree.commitUpdate fails after tree.rename in real projects, but not in unit tests #14255

Closed
filipesilva opened this issue Apr 23, 2019 · 3 comments · Fixed by #21091
Closed

tree.commitUpdate fails after tree.rename in real projects, but not in unit tests #14255

filipesilva opened this issue Apr 23, 2019 · 3 comments · Fixed by #21091
Labels
area: @angular-devkit/schematics freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Milestone
Backlog

Comments

@filipesilva
Copy link
Contributor

While testing the @angular/[email protected] update we noticed that tree.commitUpdate fails after tree.rename in real projects, but not in unit tests, and worked around it in #14252.

We should circle back and address this problem by reproducing it in isolation and fixing it.
@filipesilva filipesilva added type: bug/fix freq1: low Only reported by a handful of users who observe it rarely severity3: broken area: @angular-devkit/schematics labels Apr 23, 2019
@ngbot ngbot bot added this to the Backlog milestone Apr 23, 2019
@dgp1130
Copy link
Collaborator

dgp1130 commented May 27, 2020

@filipesilva, is this still an open issue? Not sure there's enough info here to reproduce now. Can we close this, or is there more to do here?

@filipesilva
Copy link
Contributor Author

If the problem still exists, it should be reproducible by using rename instead of create+delete as it was in the diff before https://github.com/angular/angular-cli/pull/14252/files. It didn't happen on tests though, so the migration should be ran manually on a real project.

@alan-agius4 alan-agius4 mentioned this issue Jun 9, 2021
Merged
alan-agius4 added a commit that referenced this issue Jun 9, 2021
@alan-agius4
fix(@angular-devkit/schematics): handle updating renamed files
a30525b 
With this change we fix an issue which caused a file not found error when trying to modify the file after it was renamed.

Closes #14255 and closes #21083
alan-agius4 added a commit that referenced this issue Jun 9, 2021
@alan-agius4
fix(@angular-devkit/schematics): handle updating renamed files
4b98448 
With this change we fix an issue which caused a file not found error when trying to modify the file after it was renamed.

Closes #14255 and closes #21083

(cherry picked from commit a30525b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: @angular-devkit/schematics freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix(@angular-devkit/schematics): handle updating renamed files
2 participants
@filipesilva @dgp1130