-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular v11 ignores karma plugin config karma-*
and throws error
#19993
Labels
area: @angular-devkit/build-angular
devkit/build-angular:karma
freq1: low
Only reported by a handful of users who observe it rarely
severity5: regression
type: bug/fix
Milestone
Comments
iftee-hussain
added a commit
to iftee-hussain/angular-cli
that referenced
this issue
Feb 7, 2021
Previouslt `karma-coverage` was validated only when in karma plugins config one of these was added ``'karma-coverage'` or `require('karma-coverage')` This change will allow cli to validate `karma-coverage` plugin if in `karma.conf.js` `'karma-*'` is used. Example: ``` plugins: [ ... 'karma-*', require('@angular-devkit/build-angular/plugins/karma'), ... ] ``` Fixes angular#19993
iftee-hussain
added a commit
to iftee-hussain/angular-cli
that referenced
this issue
Feb 7, 2021
…onfig Previously `karma-coverage` was validated only when in karma plugins config one of these was added ``'karma-coverage'` or `require('karma-coverage')` This change will allow cli to validate `karma-coverage` plugin if in `karma.conf.js` `'karma-*'` is used. Example: ``` plugins: [ ... 'karma-*', require('@angular-devkit/build-angular/plugins/karma'), ... ] ``` Fixes angular#19993
alan-agius4
added
the
freq1: low
Only reported by a handful of users who observe it rarely
label
Feb 7, 2021
iftee-hussain
added a commit
to iftee-hussain/angular-cli
that referenced
this issue
Feb 8, 2021
…onfig Previously `karma-coverage` was validated only when in karma plugins config one of these was added ``'karma-coverage'` or `require('karma-coverage')` This change will allow cli to validate `karma-coverage` plugin if in `karma.conf.js` `'karma-*'` is used. Example: ``` plugins: [ ... 'karma-*', require('@angular-devkit/build-angular/plugins/karma'), ... ] ``` Fixes angular#19993
clydin
pushed a commit
that referenced
this issue
Feb 8, 2021
…onfig Previously `karma-coverage` was validated only when in karma plugins config one of these was added ``'karma-coverage'` or `require('karma-coverage')` This change will allow cli to validate `karma-coverage` plugin if in `karma.conf.js` `'karma-*'` is used. Example: ``` plugins: [ ... 'karma-*', require('@angular-devkit/build-angular/plugins/karma'), ... ] ``` Fixes #19993
clydin
pushed a commit
that referenced
this issue
Feb 8, 2021
…onfig Previously `karma-coverage` was validated only when in karma plugins config one of these was added ``'karma-coverage'` or `require('karma-coverage')` This change will allow cli to validate `karma-coverage` plugin if in `karma.conf.js` `'karma-*'` is used. Example: ``` plugins: [ ... 'karma-*', require('@angular-devkit/build-angular/plugins/karma'), ... ] ``` Fixes #19993 (cherry picked from commit a7ffce1)
clydin
pushed a commit
that referenced
this issue
Feb 8, 2021
…onfig Previously `karma-coverage` was validated only when in karma plugins config one of these was added ``'karma-coverage'` or `require('karma-coverage')` This change will allow cli to validate `karma-coverage` plugin if in `karma.conf.js` `'karma-*'` is used. Example: ``` plugins: [ ... 'karma-*', require('@angular-devkit/build-angular/plugins/karma'), ... ] ``` Fixes #19993 (cherry picked from commit a7ffce1)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: @angular-devkit/build-angular
devkit/build-angular:karma
freq1: low
Only reported by a handful of users who observe it rarely
severity5: regression
type: bug/fix
🐞 Bug report
Command (mark with an
x
)Is this a regression?
karma-coverage
was made required in angular 11 and strict checking ofkarma-coverage
was also introduced in v11. So, no it is not a regressionDescription
According to https://karma-runner.github.io/6.1/config/configuration-file.html
I have added
karma-coverage
inpackage.json
and installed itand added
karma-*
to the plugins config inkarma.conf.js
Angular cli ignores the installed package as it seems
karma-*
config is ignored while validatingkarma-coverage
is installedIt works when in plugins configuration one of these is added
'karma-coverage'
orrequire('karma-coverage')
🔬 Minimal Reproduction
karma-coverage
inpackage.json
and install it (npm install
)'karma-*'
inkarma.conf.js
. Example:ng test
🔥 Exception or Error
🌍 Your Environment
Anything else relevant?
The text was updated successfully, but these errors were encountered: