Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@schematics/angular): migrate build-angular for 7.0 RC users #12697

Merged
merged 1 commit into from
Oct 31, 2018
Merged

fix(@schematics/angular): migrate build-angular for 7.0 RC users #12697

merged 1 commit into from
Oct 31, 2018

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 22, 2018

Fixes #12647

@ngbot
Copy link

ngbot bot commented Oct 22, 2018

Artifact Baseline Current Change
❕ cli/new-production/test-project/main.js 168.60KB 168.62KB +21 bytes

@filipesilva filipesilva added this to the 7.0.2 milestone Oct 23, 2018
@filipesilva
Copy link
Contributor

We might get this into 7.0.2 though.

@clydin clydin added the target: patch This PR is targeted for the next patch release label Oct 23, 2018
@clydin
Copy link
Member Author

clydin commented Oct 23, 2018

7.0.2 is already out (https://github.com/angular/angular-cli/releases/tag/v7.0.2).

@angular angular deleted a comment from ngbot bot Oct 23, 2018
@ngbot
Copy link

ngbot bot commented Oct 23, 2018

Hi @clydin! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@kyliau
Copy link
Contributor

kyliau commented Oct 23, 2018

@clydin could you please fix the merge conflict?

@clydin clydin force-pushed the rc-migrate branch 2 times, most recently from 7743cf0 to 5e388e5 Compare October 23, 2018 23:01
@clydin
Copy link
Member Author

clydin commented Oct 25, 2018

Rebased.

@kyliau kyliau merged commit 2d4332f into angular:master Oct 31, 2018
@clydin clydin deleted the rc-migrate branch November 1, 2018 00:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

ng update @angular/cli from 7.0.0-rc.1 fails to update @angular-devkit/build-angular
4 participants
@clydin @filipesilva @kyliau @googlebot