Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): change layout for root applications #13811

Merged
merged 4 commits into from
Mar 6, 2019
Merged

feat(@schematics/angular): change layout for root applications #13811

merged 4 commits into from
Mar 6, 2019

Conversation

alan-agius4
Copy link
Collaborator

This change aligns the file layout of applications generated with ng new and ng generate

@googlebot

This comment has been minimized.

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Mar 4, 2019

Block until #13797, #13780 and #13777 get merged

@alan-agius4 alan-agius4 added PR state: blocked action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: major This PR is targeted for the next major release and removed state: WIP PR state: blocked action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 4, 2019
@alan-agius4 alan-agius4 requested a review from clydin March 5, 2019 11:57
@alan-agius4 alan-agius4 marked this pull request as ready for review March 5, 2019 11:57
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both the app tsconfig and the spec tsconfig should always be under src. Every path is prefixed with src and they are only relevant to the files within src.

Otherwise, looks good.

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Mar 5, 2019

@clydin at the moment, all schematics apart from ng new generate tsconfigs outside of the src folder.

Example:

  • ng g lib
  • ng g app
  • ng g e2e

Does this mean that all these schematics should be changed to have all structures conforming with each other?

This task is to align the file structure of ng g new with that of ng g app.

At the moment, this is the ng g app layout is as follows;
screenshot 2019-03-05 at 17 39 31

Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave the tsconfig locations out of this PR and address it moving forward.

Alan added 4 commits March 6, 2019 07:29
This change aligns the file layout of applications generated with `ng new` and `ng generate`

Ref: TOOL-686
In some cases, there are still legacy projects, prior to migrations and we should not use `webdriverUpdate` and we should use headless chrome.
hansl pushed a commit that referenced this pull request Mar 6, 2019
This is a follow up on #13811, with this now all application have the same structure and hence `ng g service-worker` should follow suit and have the same folder strucute if generated in a root app, or an app inside the projects.
@hansl hansl merged commit a30ca72 into angular:master Mar 6, 2019
@alan-agius4 alan-agius4 deleted the relocate-ng-new branch March 6, 2019 19:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants