-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@schematics/angular): change layout for root applications #13811
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both the app tsconfig and the spec tsconfig should always be under src
. Every path is prefixed with src
and they are only relevant to the files within src
.
Otherwise, looks good.
@clydin at the moment, all schematics apart from Example:
Does this mean that all these schematics should be changed to have all structures conforming with each other? This task is to align the file structure of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave the tsconfig locations out of this PR and address it moving forward.
This change aligns the file layout of applications generated with `ng new` and `ng generate` Ref: TOOL-686
In some cases, there are still legacy projects, prior to migrations and we should not use `webdriverUpdate` and we should use headless chrome.
This is a follow up on #13811, with this now all application have the same structure and hence `ng g service-worker` should follow suit and have the same folder strucute if generated in a root app, or an app inside the projects.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This change aligns the file layout of applications generated with
ng new
andng generate