New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop isSupported injection, bump rxfire #3588

Merged

jamesdaniels merged 3 commits into angular:main from jamesdaniels:jamesdaniels_rxFireIsSupported

Dec 12, 2024

Member

jamesdaniels commented Dec 12, 2024 •

edited

Loading

Bump rxfire dep
Drop isSupported inject in favor of PLATFORM_ID test
Analytics is technically isPlatformBrowser rather than !isPlatformServer, prolly no diff

jamesdaniels added 3 commits

December 12, 2024 15:55


          Drop isSupported injection, bump rxfire

28278ce


          Analytics is technically !browser

edce44f


          Ditto

af60783

jamesdaniels merged commit 6b1b0ca into angular:main

6 checks passed

jamesdaniels deleted the jamesdaniels_rxFireIsSupported branch

December 12, 2024 21:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet