Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more injector safety #3590

Merged

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Dec 13, 2024

  • Zone wrapper noops for our other helpers
  • Add a warning / error on potential Zone / hydration issues
  • Pass injection context to zoneWrapFn
  • Pass injection context into the Promise wrapper
  • beforeAuthStateChanged should not block

@jamesdaniels jamesdaniels merged commit 45ccd39 into angular:main Dec 13, 2024
19 checks passed
@jamesdaniels jamesdaniels deleted the jamesdaniels_moreInjectorSafety branch December 13, 2024 21:35
@davidgeary
Copy link

@jamesdaniels Just a heads up...

I've just installed RC4 and noticed the "Firebase API called outside injection context" warning in the console. The error message also includes a link to "Find out more" pointing to https://github.com/angular/angularfire/blob/main/docs/zones.md (see line 87 in zone.ts) but this file doesn't appear to exist at the moment.

@jamesdaniels
Copy link
Member Author

@davidgeary thanks yeah, getting that page together now. You can likely safely ignore the warnings, they're only produced in dev mode and are intended to help developers track down any change-detection / rehydration instabilities

@davidgeary
Copy link

@jamesdaniels Ah, thanks. I was just starting to work through my code to see where the problem was, so you've saved me some time there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants