Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(mat-tab-nav-bar): With version 19 the ink bar lost animation when choosing a tab to the right of the active tab #30303

Closed
1 task done
bstaley opened this issue Jan 10, 2025 · 3 comments · Fixed by #30313
Closed
1 task done

bug(mat-tab-nav-bar): With version 19 the ink bar lost animation when choosing a tab to the right of the active tab #30303

bstaley opened this issue Jan 10, 2025 · 3 comments · Fixed by #30313
Assignees
@crisbeto
Labels
area: material/tabs P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@bstaley
Copy link

bstaley commented Jan 10, 2025

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

18

Description

Using mat-tab-nav-bar in version 18, no matter which tab you chose you would see the ink bar animate to that new tab. Now in 19 it only animates to the left.

Reproduction

Steps to reproduce:

  1. navigate to https://v18.material.angular.io/components/tabs/examples#tab-nav-bar-basic
  2. switch tab focus
  3. note the animation
  4. navigate to any version of 19, such as https://next.material.angular.io/components/tabs/examples
  5. choose a tab to the right
  6. note the lack of animation
  7. choose a tab to the left
  8. note the animation

Expected Behavior

Choosing a tab in any direction should animate.

Actual Behavior

Animation only happens when choosing a tab to the left of the current active.

Environment

  • Angular: ^19.0.0
  • CDK/Material: ^19.0.4
  • Browser(s): Chrome - 131.0.6778.205
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
@bstaley bstaley added the needs triage This issue needs to be triaged by the team label Jan 10, 2025
@bstaley bstaley changed the title bug(mat-tab-nav-bar): Between version 18 and 19 the ink bar lost animation when choosing and item to the right bug(mat-tab-nav-bar): With version 19 the ink bar lost animation when choosing a tab to the right of the active tab Jan 10, 2025
@crisbeto
Copy link
Member

Which animation are you referring to? It seems to work as expected to me.

@crisbeto
Copy link
Member

Also here a recording of how it looks on my end:

Screen.Recording.2025-01-10.at.21.09.32.mov

@crisbeto
Copy link
Member

Ah I see what you mean. It's only on the nav bar.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: material/tabs and removed needs triage This issue needs to be triaged by the team labels Jan 10, 2025
@crisbeto crisbeto mentioned this issue Jan 12, 2025
Closed
1 task
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 13, 2025
@crisbeto
fix(material/tabs): tab nav bar animation not working when navigating…
cbfad6f 
… forwards

Fixes a regression introduced in angular#30121. It looks like we were depending on the incorrect internal state to animate correctly.

These changes fix the issue by removing a call that was redundant in the first place.

Fixes angular#30303.
@crisbeto crisbeto self-assigned this Jan 13, 2025
@crisbeto crisbeto mentioned this issue Jan 13, 2025
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 13, 2025
@crisbeto
fix(material/tabs): tab nav bar animation not working when navigating…
38086cc 
… forwards

Fixes a regression introduced in angular#30121. It looks like we were depending on the incorrect internal state to animate correctly.

These changes fix the issue by removing a call that was redundant in the first place.

Fixes angular#30303.
crisbeto added a commit that referenced this issue Jan 13, 2025
@crisbeto
fix(material/tabs): tab nav bar animation not working when navigating…
59a7985 
… forwards (#30313)

Fixes a regression introduced in #30121. It looks like we were depending on the incorrect internal state to animate correctly.

These changes fix the issue by removing a call that was redundant in the first place.

Fixes #30303.
crisbeto added a commit that referenced this issue Jan 13, 2025
@crisbeto
fix(material/tabs): tab nav bar animation not working when navigating…
de8c687 
… forwards (#30313)

Fixes a regression introduced in #30121. It looks like we were depending on the incorrect internal state to animate correctly.

These changes fix the issue by removing a call that was redundant in the first place.

Fixes #30303.

(cherry picked from commit 59a7985)
crisbeto added a commit that referenced this issue Jan 13, 2025
@crisbeto
fix(material/tabs): tab nav bar animation not working when navigating…
6ca21fd 
… forwards (#30313)

Fixes a regression introduced in #30121. It looks like we were depending on the incorrect internal state to animate correctly.

These changes fix the issue by removing a call that was redundant in the first place.

Fixes #30303.

(cherry picked from commit 59a7985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crisbeto crisbeto

Labels
area: material/tabs P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/tabs): tab nav bar animation not working when navigating forwards crisbeto/material2
2 participants
@bstaley @crisbeto