fix(material/menu): Update token values and styles for M3 #28470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amysorto
force-pushed
the
menu-m3-fixes
branch
from
0f32154 to
0afcf36
Compare
amysorto
added
area: material/menu
material spec
amysorto
requested review from
mmalerba,
andrewseguin and
crisbeto
as code owners
amysorto
added
the
dev-app preview
|
Deployed dev-app for 16bea50 to: https://ng-dev-previews-comp--pr-angular-components-28470-dev-tsubl0zh.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
amysorto
added
the
action: review
amysorto
force-pushed
the
menu-m3-fixes
branch
from
0afcf36 to
16bea50
Compare
mmalerba
pushed a commit
that referenced
this pull request
Feb 9, 2024
bileschi
pushed a commit
to tensorflow/tensorboard
that referenced
this pull request
Feb 9, 2024
## Motivation for features / changes Override the CSS variable (part of M3 work done here: angular/components#28470) that now exists for icon size in menu, the correct way of overriding this value. ## Technical description of changes ## Screenshots of UI changes (or N/A) Slight padding changes will show in screenshots, the menu is now closer to the M2 spec. ## Detailed steps to verify changes work correctly (as executed by you) ## Alternate designs / implementations considered (or N/A)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.