Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): fix M3 styles #28556

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix(material/datepicker): fix M3 styles #28556

merged 2 commits into from
Feb 9, 2024

Conversation

andrewseguin
Copy link
Contributor

  • Use elevation 0
  • Make large round corners
  • Change menu button text to surface variant
  • Remove bottom border below days
  • Fix demo so that the color is passed through

@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Feb 7, 2024
@mmalerba mmalerba added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Feb 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024 •
edited
Loading

Deployed dev-app for e790ca9 to: https://ng-dev-previews-comp--pr-angular-components-28556-dev-sze9s19l.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

mmalerba
mmalerba approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Feb 7, 2024
crisbeto
crisbeto reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do it in a follow-up, but the touch UI mode doesn't seem to match the dialog spec for the shape and elevation.

@andrewseguin
Copy link
Contributor Author

Thanks - I didn't check that bit. I'll continue to iterate on the datepicker. There's a few other spots that aren't quite up to spec but might cause more screenshot failures

@andrewseguin andrewseguin added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Feb 9, 2024
@andrewseguin andrewseguin removed the request for review from zarend February 9, 2024 17:06
@andrewseguin andrewseguin merged commit 206f0fc into angular:main Feb 9, 2024
25 of 26 checks passed
andrewseguin added a commit that referenced this pull request Feb 9, 2024
@andrewseguin
fix(material/datepicker): fix M3 styles (#28556)
873c8e9 
* fix(material/datepicker): fix M3 styles

* fix(material/datepicker): fix m2 text button color

(cherry picked from commit 206f0fc)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewseguin @crisbeto @mmalerba