fix(cdk/drag-drop): defer loading reset styles #29056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,6 +29,23 @@ const activeCapturingEventOptions = normalizePassiveListenerOptions({ | |||
| capture: true, | |||
| }); | |||
|
|
|||
| /** Keeps track of the apps currently containing badges. */ | |||
There was a problem hiding this comment.
nit: change "badges" to be about drag-and-drop
There was a problem hiding this comment.
This definitely didn't happen because the implementation is the same as the badge...
andrewseguin
approved these changes
May 16, 2024
Currently we load the reset styles for the preview up-front which seems to break some Jest tests since Jest's CSS parser does't understand layers. These changes switch to loading the styles only once dragging has started. Fixes angular#29053.
crisbeto
force-pushed
the
29053/defer-resets
branch
from
69b6966 to
8d53f43
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we load the reset styles for the preview up-front which seems to break some Jest tests since Jest's CSS parser doesn't understand layers.
These changes switch to loading the styles only once dragging has started.
Fixes #29053.