Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inline-resources): remove module ids from component metadata. #984

Merged
merged 1 commit into from
Aug 10, 2016

Conversation

devversion
Copy link
Member

Removes the module ids of the component metadata.

Since the templates and styles are now inlined, the module id has become unnecessary and can cause unexpected issues.

This also fixes #974 in meanwhile.

FYI: The regex is designed to match the whole line (including line feeds) and only the compiler specific module ids.

> Removes the module ids of the component metadata.
> Since the templates and styles are now inlined, the module id has become unnecessary and
> can cause unexpected issues

This also fixes angular#974 in meanwhile.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 10, 2016
@aminebizid
Copy link

Do we have to wait for alpha.8.
This is a very blocker issue for Webpack and doing this is very expensive :

   {
           test: /.js$/,
           loader: 'string-replace-loader',
           query: {
             search: 'moduleId: module.id,',
             replace: '',
             flags: 'g'
           }
          }

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn merged commit 7f594ce into angular:master Aug 10, 2016
@devversion devversion deleted the fix/inline-remove-module-ids branch August 10, 2016 18:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(rc5 and alpha7)url_resolver.js:238Uncaught TypeError: uri.match is not a function
4 participants