Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NFTMarketplace.sol #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xScratch
Copy link

Two main changes took place here:

  1. Struct packing: Reference. Also changed some of the values where these structs are initialized, which led the event to affect (just for a good readability)
  2. For loops improvement: The 'for' loop used earlier costs more gas than this one. Usage of unchecked happens when we are pretty sure that this unsigned integer won't overflow.

Thanks @anhfactor

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celopunk-auction ❌ Failed (Inspect) Nov 21, 2023 4:17pm

Repository owner deleted a comment from Bridgewaters01 Feb 2, 2024
Repository owner deleted a comment from katsavav Feb 5, 2024
Repository owner deleted a comment from andrewluetgers Feb 23, 2024
Repository owner deleted a comment from andrewluetgers Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant