Skip to content
This repository has been archived by the owner on Jul 21, 2024. It is now read-only.

Muscle system is flawed #183

Closed
animate1978 opened this issue Nov 3, 2019 · 0 comments
Closed

Muscle system is flawed #183

animate1978 opened this issue Nov 3, 2019 · 0 comments

Comments

@animate1978
Copy link
Owner

animate1978 commented Nov 3, 2019 •
edited
Loading

Describe the bug
As reported by a user (angavrilov) on BlenderArtists -

.... It has a big conceptual problem inherited from the original version, that the rig produces transformation in the rest pose due to poorly thought through constraints. This is generally considered bad rig design, and in MB-Lab, this transformation is actually baked into the generated character and thus applied twice.

Additional context
Honestly I am not entirely positive what the issue is, I am assuming that what is said is correct. The Muscles are buggy as it is, see this - #131

This needs to be tested by someone that has experience with rigging
angavrilov added a commit to angavrilov/MB-Lab that referenced this issue Nov 4, 2019
@angavrilov
Fix animate1978#183, animate1978#131: the muscle rig causes deformati…
dbc44f7 
…on in rest pose.

- Certain bones have to be precisely aligned to the rotation of
  a specific other bone, which required new code.
- Stretch to has to be applied to the muscle bones while fitting.
- B-Bone handles and certain constraints have to be fixed in the
  library file via a script.
angavrilov added a commit to angavrilov/MB-Lab that referenced this issue Nov 4, 2019
@angavrilov
Fix animate1978#183, animate1978#131: the muscle rig causes deformati…
c30e407 
…on in rest pose.

- Certain bones have to be precisely aligned to the rotation of
  a specific other bone, which required new code.
- Stretch to has to be applied to the muscle bones while fitting.
- B-Bone handles and certain constraints have to be fixed in the
  library file via a script.
animate1978 pushed a commit that referenced this issue Dec 7, 2019
@angavrilov
Fix #183, #131: the muscle rig causes deformation in rest pose.
6f5a6b3 
- Certain bones have to be precisely aligned to the rotation of
  a specific other bone, which required new code.
- Stretch to has to be applied to the muscle bones while fitting.
- B-Bone handles and certain constraints have to be fixed in the
  library file via a script.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@animate1978