Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styling for Anki's and Anki Mobile's built-in dark mode #173

Merged
merged 1 commit into from
Nov 17, 2019

Conversation

aplaice
Copy link
Collaborator

@aplaice aplaice commented Nov 17, 2019

This deals with the issue of the info (and "type") text being displayed as dark grey on black.

This is not necessary for Ankidroid, since Ankidroid dark mode automatically inverts all text colours, but doesn't hurt either.

Once #156 is resolved, one could consider adding a selector for .night_mode, for the popular dark-mode add-on. (Until then there are more serious (breaking) issues with the combination of ultimate geography with the add-on.)

@axelboc axelboc added content Content changes, map improvements, translation fixes, etc. structure Templates, tags, generated decks, etc. and removed content Content changes, map improvements, translation fixes, etc. labels Nov 17, 2019
@axelboc axelboc added this to the v3.3 milestone Nov 17, 2019
This deals with the issue of the info (and "type") text being
displayed as dark grey on black.

This is not necessary for Ankidroid, since Ankidroid dark mode
automatically inverts all text colours, but doesn't hurt either.

Once anki-geo#156 is resolved, one could consider adding a selector for
.night_mode, for the popular dark-mode add-on.
@ukanuk
Copy link
Contributor

ukanuk commented Feb 18, 2020

Note on the latest 2.1.20 release, Anki Desktop now recognizes .night_mode just like on AnkiDroid. See this comment on the 2.1.20 beta page (though it's no longer in beta and is fully released).

Therefore if/when #156 is resolved, instead of adding .night_mode which would be redundant, I'd recommend replacing .nightMode with .night_mode.

ukanuk added a commit to ukanuk/anki-ultimate-geography that referenced this pull request Apr 7, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Exact cause not fully explored, but suspect the addition of one `.night_mode` class causes AnkiDroid to stop automatically inverting any colors. Therefore, the Anki Desktop-only `.nightMode` changes to `.night_mode` to cause proper colors on AnkiDroid as well as Anki Desktop. This should also be regression tested on Anki Mobile (iPhone app), which I am unable to do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
structure Templates, tags, generated decks, etc.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants