Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode not correctly setting theme colors in card area of Reviewer #5127

Closed
jottr opened this issue Nov 23, 2018 · 1 comment
Closed

Dark mode not correctly setting theme colors in card area of Reviewer #5127

jottr opened this issue Nov 23, 2018 · 1 comment
Assignees
@mikehardy
Labels
Accepted Maintainers welcome a PR implementing this feature Bug

Comments

@jottr
Copy link

jottr commented Nov 23, 2018 •
edited
Loading

Reproduction Steps

Switch on Night Mode.
It doesn't matter if one sets the Theme to "Dark" or "Black".
Card background is always 100% black.

Pure black backgrounds should be avoided from an UX perspective. It increases eyestrain and decreases legibility.

I suggest that the card background should be toned down a bit.
mikehardy added a commit to mikehardy/Anki-Android that referenced this issue Nov 23, 2018
@mikehardy
Extend alternative themes into Reviewer by emitting CSS selectors
c725c4c 
Fixes ankidroid#5127 by extending the "dark" (vs black) theme into the reviewer,
previously dark theme was ignored in the HTML/CSS emitted if you had
selected it - there was only white and black

"plain" mode (the "white" alternative theme) doesn't affect the reviewer colors so
doesn't need any overrides in the CSS file but we emit the selector in case
others want to use it
@mikehardy mikehardy mentioned this issue Nov 23, 2018
Merged
@mikehardy
Copy link
Member

mikehardy commented Nov 23, 2018 •
edited
Loading

Ah, I see what you mean. The "dark" (vs "Black") setting doesn't affect card background while it does affect the other areas.

I just poked around in the area and I think #5128 fixes it assuming it passes review

@mikehardy mikehardy self-assigned this Nov 23, 2018
@mikehardy mikehardy added Bug Accepted Maintainers welcome a PR implementing this feature labels Nov 23, 2018
@mikehardy mikehardy changed the title Night mode: Background color should not be pure black Dark mode not correctly setting theme colors in card area of Reviewer Nov 23, 2018
@mikehardy mikehardy mentioned this issue Dec 21, 2018
Merged
mikehardy added a commit to mikehardy/Anki-Android that referenced this issue Jan 5, 2019
@mikehardy
Extend alternative themes into Reviewer by emitting CSS selectors
e7f2113 
Fixes ankidroid#5127 by extending the "dark" (vs black) theme into the reviewer,
previously dark theme was ignored in the HTML/CSS emitted if you had
selected it - there was only white and black

"plain" mode (the "white" alternative theme) doesn't affect the reviewer colors so
doesn't need any overrides in the CSS file but we emit the selector in case
others want to use it
mikehardy added a commit to mikehardy/Anki-Android that referenced this issue Jan 7, 2019
@mikehardy
Extend alternative themes into Reviewer by emitting CSS selectors
3a5fcdf 
Fixes ankidroid#5127 by extending the "dark" (vs black) theme into the reviewer,
previously dark theme was ignored in the HTML/CSS emitted if you had
selected it - there was only white and black

"plain" mode (the "white" alternative theme) doesn't affect the reviewer colors so
doesn't need any overrides in the CSS file but we emit the selector in case
others want to use it
timrae pushed a commit that referenced this issue Feb 3, 2019
@mikehardy @timrae
Extend alternative themes into Reviewer by emitting CSS selectors
2bca8ad 
Fixes #5127 by extending the "dark" (vs black) theme into the reviewer,
previously dark theme was ignored in the HTML/CSS emitted if you had
selected it - there was only white and black

"plain" mode (the "white" alternative theme) doesn't affect the reviewer colors so
doesn't need any overrides in the CSS file but we emit the selector in case
others want to use it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikehardy mikehardy

Labels
Accepted Maintainers welcome a PR implementing this feature Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikehardy @jottr