Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Broken/Outdated Link #304

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Update Broken/Outdated Link #304

merged 2 commits into from
Nov 23, 2024

Conversation

brishtibheja
Copy link
Contributor

@brishtibheja brishtibheja commented Nov 19, 2024


One other thing that we can do to help users is put a div with learning-relearning/review-cards id in here:
https://github.com/ankitects/anki-manual/blob/main/src/studying.md?plain=1#L79

Or maybe there's a better way? We want people to go to deck options section to find out how answer button intervals work.

@Expertium
Copy link
Contributor

Expertium commented Nov 20, 2024

https://docs.ankiweb.net/studying.html#how-to-choose-the-answer-button is also broken, the new one is https://docs.ankiweb.net/studying.html#answer-buttons. Ideally, we should keep using the previous one. This is definitely in the "frequently used" category, since Danika and my bot used it on Reddit

@brishtibheja
Copy link
Contributor Author

I figured there aren't that many of these lying around so we probably can just correct the link from here on.

@Expertium
Copy link
Contributor

So are you saying that we should use https://docs.ankiweb.net/studying.html#how-to-choose-the-answer-button or that we should use https://docs.ankiweb.net/studying.html#answer-buttons? I can't tell.
I think we should use the previous link to avoid breaks.

@@ -144,7 +144,7 @@ This option can be useful if you wish to study individual subdecks, while enforc
## New Cards

The options here only affect new cards and
[learning cards](studying.md#learningrelearning-cards). Once a card
[learning cards](getting-started.md#card-states). Once a card
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right link to substitute? It doesn't have the same information as the moved/removed section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That info was moved to this very topic.

@Danika-Dakika
Copy link
Collaborator

This is a partial fix -- but if this is proposed as a fix to #303, it needs to also fix jumplinks to the headers you removed.

@dae
Copy link
Member

dae commented Nov 23, 2024

I appreciate you updating the links, but agree with the others that we should also be adding the old anchors back if they were in use.

@dae
Copy link
Member

dae commented Nov 23, 2024

(merging this in as it's an improvement, but will avoid closing the issue)

@dae dae merged commit 01f408d into ankitects:main Nov 23, 2024
@brishtibheja brishtibheja deleted the update-link branch November 23, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants