Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Text File Section #317

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

brishtibheja
Copy link
Contributor

A little polishing and I removed some outdated info I thought isn't necessary anymore.

@@ -12,10 +12,6 @@ are met.

- The files must be in UTF-8 format (see below).

- The first line also defines the separating character – if Anki finds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is still true (though it could be worded better). If no separator has been specified, the contents of the first field will control what Anki guesses it should be.

Copy link
Contributor Author

@brishtibheja brishtibheja Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But as people can change it, does it really needs documented?

It's also a awkward place for the info to be in. I'll try to get another PR for here explaining each option individually. Better do it then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it could be mentioned in the separator section of the table below instead for example.

the following to the top of the text file:

tags:tag1 tag2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is distinct from the tags: entry below - note how the first line doesn't need a comment. But I'd prefer we push people to use the more consistent approach mentioned below, so I think it's ok to remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's what I thought too.

@dae dae merged commit 0f9cfa4 into ankitects:main Dec 23, 2024
@brishtibheja brishtibheja deleted the update-text-files branch December 23, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants