Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all add-on links #31

Merged
merged 10 commits into from
Sep 7, 2024
Merged

Update all add-on links #31

merged 10 commits into from
Sep 7, 2024

Conversation

brishtibheja
Copy link
Contributor

I found two with broken links. For another, gave links to Shige's add on as it has better reviews.
But why do we link people to an add-on for resetting cards? That can be done using the "Reset" option in browser. Should we link to the browsing section of manual instead? As of now, I just changed the links.

Copy link
Collaborator

@Danika-Dakika Danika-Dakika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the docs we need to be careful not to be seen as giving preferential ranking to one dev's add-ons over another for no reason. You mention "better reviews," but neither of the substitute versions had better reviews that the original versions (and one didn't even have the correct functionality).

src/changing-the-font.md Outdated Show resolved Hide resolved
src/resetting-progress-in-a-deck.md Outdated Show resolved Hide resolved
src/splitting-a-field-into-multiple-fields.md Show resolved Hide resolved
src/splitting-a-field-into-multiple-fields.md Outdated Show resolved Hide resolved
@brishtibheja
Copy link
Contributor Author

About the advice for f.pixelSize(), fontHeight I am not sure applies to this add-on. If you or dae can check what it does, I can either remove this or replace this with something else if needed.

src/changing-the-font.md Outdated Show resolved Hide resolved
src/changing-the-font.md Outdated Show resolved Hide resolved
src/splitting-a-field-into-multiple-fields.md Outdated Show resolved Hide resolved
@dae
Copy link
Member

dae commented Aug 15, 2024

The concerns about favouritism are reasonable, but in the add note id case, we'll want to rewrite that section anyway.

The linked add-on removes card review history, which Anki doesn't do itself. Or have I misunderstood the question?

Are you both happy for me to merge this?

@brishtibheja
Copy link
Contributor Author

I originally linked a different one which resets most counters but doesn't permanently remove anything. It's all good now.

@dae
Copy link
Member

dae commented Sep 7, 2024

Thank you both!

@dae dae merged commit c5c3c35 into ankitects:main Sep 7, 2024
@brishtibheja brishtibheja deleted the patch branch September 7, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants